-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging, Add logging per VM #724
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 62.59% 62.57% -0.03%
==========================================
Files 69 70 +1
Lines 6152 6233 +81
Branches 500 503 +3
==========================================
+ Hits 3851 3900 +49
- Misses 2151 2180 +29
- Partials 150 153 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put a suggestion about the log level, but the rest looks so good 😃 🚀
e4a4e98
to
d30785a
Compare
Solution: Add ContextManager that allow showing which VM is currently acted uppon, making log easier far more useful
Co-authored-by: nesitor <[email protected]>
ea557ff
to
346d9fc
Compare
Split of from #719 , better reviewability.
Improve the logging for ALEPH-VM
This is a lot of small improvement to make aleph-vm more usable. I'm putting them all under the banner of the Jira tickets : ALEPH-166
hatch fmt
command (andruff fmt
)Related ClickUp, GitHub or Jira tickets :Part of ALEPH-166 Epic
Self proofreading checklist
packaging/Makefile
Changes
Explain the changes that were made. The idea is not to list exhaustively all the changes made (GitHub already provides a full diff), but to help the reviewers better understand:
How to test
Use is as usual.