Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Log level could not be configured from settings #581

Closed
wants to merge 2 commits into from

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 19, 2024

Solution: Add a LOG_LEVEL setting defaulting to "WARNING".

Copy link

  • Changes to configuration settings in src/aleph/vm/conf.py, including enabling or disabling system logs and setting log level.
  • Addition of new features like logging levels and debugging options in src/aleph/vm/orchestrator/cli.py.
  • Introduces several breaking changes that may require extensive testing before they can be merged into the main branch.

Please note, only experienced developers should review this PR as it involves significant architectural changes and potential for introducing bugs or instability. The label 'BLACK' is used sparingly to indicate these high risk PRs.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.66%. Comparing base (46063fb) to head (002a20a).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   62.66%   62.66%           
=======================================
  Files          68       68           
  Lines        6029     6030    +1     
  Branches      638      638           
=======================================
+ Hits         3778     3779    +1     
  Misses       2101     2101           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@hoh hoh force-pushed the hoh-log-level-in-settings branch 2 times, most recently from 75d9aee to 87160c4 Compare April 9, 2024 12:44
@hoh hoh force-pushed the hoh-log-level-in-settings branch from 87160c4 to 71cf478 Compare April 26, 2024 11:15
@olethanh olethanh force-pushed the hoh-log-level-in-settings branch from 71cf478 to 9afee87 Compare June 18, 2024 10:52
@olethanh
Copy link
Collaborator

rebased on main

@olethanh olethanh force-pushed the hoh-log-level-in-settings branch from 9afee87 to 0d2a1ac Compare September 2, 2024 09:30
src/aleph/vm/orchestrator/cli.py Outdated Show resolved Hide resolved
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".
@olethanh olethanh force-pushed the hoh-log-level-in-settings branch from 0d2a1ac to fdbf4b0 Compare September 2, 2024 10:17
Copy link
Collaborator

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it and it doesn't seems to work

olethanh added a commit that referenced this pull request Oct 29, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 4, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 5, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 5, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 13, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 18, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
@olethanh olethanh mentioned this pull request Nov 18, 2024
7 tasks
olethanh added a commit that referenced this pull request Nov 18, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 20, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
olethanh added a commit that referenced this pull request Nov 20, 2024
Solution: Add a `LOG_LEVEL` setting defaulting to "WARNING".

Replace PR #581

#581
@olethanh
Copy link
Collaborator

Replaced by #724 which implement the feature

@olethanh olethanh closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants