Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small type fixes #5690

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: small type fixes #5690

merged 1 commit into from
Dec 13, 2024

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Dec 6, 2024

Issue #, if available: NA

Description of changes:

  • mark event as optional in endOperation to be inline with the previously defined types.
  • mark config as optional in the contstructor of SyntaxMode.HighlightRules to be inline with the previously defined types.
  • Expose $onChange and $syncOptions from SearchBox to expose these methods to users building custom search boxes based on the SearchBox implementation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

github-actions bot commented Dec 6, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (3eaf667) to head (0c5dc55).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5690   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         598      598           
  Lines       43588    43588           
  Branches     7162     7162           
=======================================
  Hits        37932    37932           
  Misses       5656     5656           
Flag Coverage Δ
unittests 87.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman changed the title [WIP] chore: small type fixes chore: small type fixes Dec 9, 2024
@akoreman akoreman marked this pull request as ready for review December 9, 2024 11:07
@nlujjawal nlujjawal self-requested a review December 9, 2024 12:15
@akoreman akoreman merged commit c3f548b into ajaxorg:master Dec 13, 2024
4 checks passed
@mkslanc mkslanc mentioned this pull request Dec 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants