WIP: Improve types #5691
WIP: Improve types #5691
Conversation
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
Hey @mkslanc, thanks for the PR! I think it's a step in the right direction, is there anything blocking it from being ready for review? |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
| @@ -1554,7 +1564,3 @@ declare module "./src/mouse/default_gutter_handler" { | |||
| } | |||
| } | |||
|
|
|||
| declare module "./src/lib/keys" { | |||
There was a problem hiding this comment.
Missed this during the initial review, what was the reason for removing the type declaration of lib/keys?
There was a problem hiding this comment.
Actually that was wrong, It exported only one function without repeating structure for this module, which is wild mix of
oop.mixin(exports, Keys);
exports.default = exports;
exports.keyCodeToString
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: