Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(destination-firebolt): disable on-disk token caching #51560

Merged
merged 4 commits into from
Jan 21, 2025
Merged

fix(destination-firebolt): disable on-disk token caching #51560

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8c783d
fix(destination-firebolt): disable on-disk token caching
ptiurin Jan 15, 2025
5434225
back to old formatting
ptiurin Jan 15, 2025
8e926da
version and changelog
ptiurin Jan 17, 2025
48d3fdb
bump pyproject.toml
ptiurin Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/destination-firebolt/destination_firebolt/destination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ def _determine_auth(key: str, secret: str) -> Auth:
"""
if "@" in key:
# email auth can only be used with UsernamePassword
return UsernamePassword(key, secret)
return UsernamePassword(key, secret, use_token_cache=False)
else:
return ClientCredentials(key, secret)
return ClientCredentials(key, secret, use_token_cache=False)


def parse_config(config: json, logger: Optional[logging.Logger] = None) -> Dict[str, Any]:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-firebolt/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: database
connectorType: destination
definitionId: 18081484-02a5-4662-8dba-b270b582f321
dockerImageTag: 0.2.25
dockerImageTag: 0.2.26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptiurin can you also change the version in pyproject file?

destination-firebolt - ❌ Failed - Connector version in metadata.yaml and pyproject.toml file must match: Version is 0.2.26 in metadata.yaml, but version is 0.2.25 in pyproject.toml. These two files have to be consistent.

After that I'll trigger CI and run tests

dockerRepository: airbyte/destination-firebolt
githubIssueLabel: destination-firebolt
connectorBuildOptions:
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/firebolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ Firebolt. Each table will contain 3 columns:

| Version | Date | Pull Request | Subject |
|:--------| :--------- | :------------------------------------------------------- | :------------------------------------- |
| 0.2.26 | 2025-01-17 | [51560](https://github.com/airbytehq/airbyte/pull/51560) | Fix connection issues |
| 0.2.25 | 2024-11-25 | [48672](https://github.com/airbytehq/airbyte/pull/48672) | Update dependencies |
| 0.2.24 | 2024-10-29 | [47780](https://github.com/airbytehq/airbyte/pull/47780) | Update dependencies |
| 0.2.23 | 2024-10-28 | [47100](https://github.com/airbytehq/airbyte/pull/47100) | Update dependencies |
Expand Down
Loading