fix(destination-firebolt): disable on-disk token caching #51560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ptiurin is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
ptiurin
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
ptiurin
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
ptiurin
force-pushed
the
fix-firebolt-permission-error
branch
from
023e464 to
5434225
Compare
ptiurin
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
marcosmarxm
requested changes
Jan 17, 2025
octavia-squidington-iii
added
the
area/documentation
ptiurin
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Ok, done. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ptiurin can you bump the version in the pyproject.toml? Looks like this is failing: |
ptiurin
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Sure, updated. |
marcosmarxm
approved these changes
Jan 21, 2025
| @@ -2,7 +2,7 @@ data: | |||
| connectorSubtype: database | |||
| connectorType: destination | |||
| definitionId: 18081484-02a5-4662-8dba-b270b582f321 | |||
| dockerImageTag: 0.2.25 | |||
| dockerImageTag: 0.2.26 | |||
There was a problem hiding this comment.
@ptiurin can you also change the version in pyproject file?
destination-firebolt - ❌ Failed - Connector version in metadata.yaml and pyproject.toml file must match: Version is 0.2.26 in metadata.yaml, but version is 0.2.25 in pyproject.toml. These two files have to be consistent.
After that I'll trigger CI and run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently the latest(0.2.25) Firebolt destination version is failing to connect due to the disk access error from the OS.
This is due to the SDK caching a token for future use on the file system. New
airbyteuser introduced in the latest python base does not have permissions to access the required directory.How
Setting the flag to False disables an attempt to cache on filesystem, designed specifically for constrained environments.
User Impact
Firebolt destination will be usable again. Behind the scenes an additional http request will be run when establishing a connection, but this will barely impact timings overall.
Can this PR be safely reverted and rolled back?