Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Destination Redshift: GA Destinations V2 #34077

Merged
merged 14 commits into from
Jan 24, 2024
Merged

✨ Destination Redshift: GA Destinations V2 #34077

merged 14 commits into from
Jan 24, 2024

Conversation

cynthiaxyin
Copy link
Contributor

closes #31592

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2024 11:43pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited by cynthiaxyin
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@cynthiaxyin cynthiaxyin changed the title ✨ Destination Redshift: GA Destinations V2 [WIP] ✨ Destination Redshift: GA Destinations V2 Jan 10, 2024
@cynthiaxyin
Copy link
Contributor Author

cynthiaxyin commented Jan 10, 2024 •
edited
Loading

turning off draft mode to run tests

edit: ~50 integration tests failed, moving back to draft

@cynthiaxyin cynthiaxyin marked this pull request as ready for review January 10, 2024 00:44
@cynthiaxyin cynthiaxyin requested a review from a team as a code owner January 10, 2024 00:44
evantahler
evantahler approved these changes Jan 10, 2024
View reviewed changes
airbyte-integrations/connectors/destination-redshift/metadata.yaml Outdated
dockerImageTag: 0.7.14
dockerImageTag: 2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't talk about redshift 1.0

@cynthiaxyin cynthiaxyin marked this pull request as draft January 10, 2024 01:31
@cynthiaxyin cynthiaxyin marked this pull request as ready for review January 10, 2024 21:37
@cynthiaxyin cynthiaxyin changed the title [WIP] ✨ Destination Redshift: GA Destinations V2 ✨ Destination Redshift: GA Destinations V2 Jan 11, 2024
jbfbell
jbfbell suggested changes Jan 12, 2024
View reviewed changes
airbyte-integrations/connectors/destination-redshift/metadata.yaml Outdated
dockerImageTag: 0.7.14
dockerImageTag: 2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't talk about redshift 1.0

airbyte-integrations/connectors/destination-redshift/src/main/resources/spec.json Show resolved Hide resolved
@cynthiaxyin cynthiaxyin requested a review from jbfbell January 12, 2024 02:34
@cynthiaxyin cynthiaxyin force-pushed the cynthia/redshift_ga branch 2 times, most recently from 63a4215 to b688890 Compare January 17, 2024 00:33
@cynthiaxyin cynthiaxyin mentioned this pull request Jan 17, 2024
Closed
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 19, 2024
@cynthiaxyin cynthiaxyin added the breaking-change Don't merge me unless you are ready. label Jan 19, 2024
@cynthiaxyin cynthiaxyin requested a review from a team January 23, 2024 22:02
@cynthiaxyin
Copy link
Contributor Author

cynthiaxyin commented Jan 23, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7632880845
✅ Successfully published Java CDK version=0.13.3!

@cynthiaxyin cynthiaxyin merged commit 13e32a6 into master Jan 24, 2024
24 checks passed
@cynthiaxyin cynthiaxyin deleted the cynthia/redshift_ga branch January 24, 2024 00:02
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@cynthiaxyin @gisripa @jatinyadav-cc
✨ Destination Redshift: GA Destinations V2 (airbytehq#34077)
bbe637f 
Signed-off-by: Gireesh Sreepathi <[email protected]>
Co-authored-by: Gireesh Sreepathi <[email protected]>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@cynthiaxyin @gisripa @jatinyadav-cc
✨ Destination Redshift: GA Destinations V2 (airbytehq#34077)
0eb6c8d 
Signed-off-by: Gireesh Sreepathi <[email protected]>
Co-authored-by: Gireesh Sreepathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbfbell jbfbell jbfbell approved these changes

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. CDK Connector Development Kit connectors/destination/bigquery connectors/destination/redshift connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redshift V2: handle breaking change release
5 participants
@cynthiaxyin @evantahler @jbfbell @octavia-squidington-iii @gisripa