Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1s1t for Redshift #31223

Closed
evantahler opened this issue Oct 10, 2023 · 12 comments · Fixed by #32326
Closed

1s1t for Redshift #31223

evantahler opened this issue Oct 10, 2023 · 12 comments · Fixed by #32326
Assignees
Labels
Epic team/destinations Destinations team's backlog

Comments

@evantahler
Copy link
Contributor

evantahler commented Oct 10, 2023

  • Redshift gets the Dv2 treatment
  • Also include price data in perf dashboard(s)
  • Speed and Cost fit perf constraints above across many sizes of sync
  • manage rollout (3 beta users)

SqlGenerator
CatalogParser
Normalization into container (but we need to roll it out)
V1->V2 migrator
Make it work


migration (v1-->v2)
full refresh
incremental

@evantahler evantahler added team/destinations Destinations team's backlog Epic labels Oct 10, 2023
@evantahler evantahler assigned cynthiaxyin and jbfbell and unassigned cynthiaxyin and jbfbell Oct 10, 2023
@pranasziaukas
Copy link

manage rollout (3 beta users)

Is it still possible to participate in the upcoming beta rollout @evantahler? cc @cynthiaxyin

I filled some form in the summer stating that we'd be interested in trying out the Redshift destination V2.

@cynthiaxyin
Copy link
Contributor

@pranasziaukas Thanks for your interest! Yes, it is still possible and you can track the progress of this project on this issue. #31575 is likely where we will add updates about the beta rollout. cc @evantahler

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

What’s been completed:

  • draft PR being collaborated on
  • Cynthia, Ed, and Gireesh met to walk through the code and generate a shortlist of TODO's
  • 23 beta users contacted with a "coming soon" email

📚 Learnings and hurdles:

  • beta users are excited!
  • some of the existing destinations code structure could be better organized
    • Gireesh documented some of the current flow

🚫 Blockers:

  • folks got sick

🌱 Looking ahead:

  • more collaboration and progress on the code (SqlGenerator, migration code, etc.)
  • Cynthia working on documenting our process for future implementations of Destinations V2

@cynthiaxyin
Copy link
Contributor

cynthiaxyin commented Nov 29, 2023

Redshift Destinations V2 weekly update:

What’s been completed:

  • lots of progress on the Dv2 implementation!
    • RedshiftSqlGenerator and migration code are complete
    • Redshift Dv2 and T&D test suites are all passing

📚 Learnings and hurdles:

  • the Dv2 test suites are pretty high-effort to set up, but they pay off very quickly in terms of leverage

🚫 Blockers:

  • minimal dev time last week due to hack days + holidays

🌱 Looking ahead:

  • move Redshift standard inserts onto the async framework to reduce duplicate/throwaway work
  • plug T&D into the rest of the connector (standard inserts and S3 staging)
  • release the first beta image once one loading method is working (targeting next week)
  • beta user group will receive comms and be added to a private Slack channel when the first beta image is released

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

What’s been completed:

  • moved Redshift standard inserts onto the async framework
  • Dv2 is ready for beta testing (both standard inserts and S3 staging) with green build and passing tests

📚 Learnings and hurdles:

🚫 Blockers:

  • none

🌱 Looking ahead:

  • investigating memory consumption footprint after switching Dv1 standard inserts to async
  • final PR review and performance testing
  • release the beta!
    • beta user group will receive comms and be added to a private Slack channel

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

What’s been completed:

  • launched the beta! 🎉
  • invited ~20 users to try it out #ext-destinations-v2-redshift-beta

📚 Learnings and hurdles:

  • beta user has already given us valuable feedback around data types, permissions, and optimizations

🚫 Blockers:

  • none

🌱 Looking ahead:

  • continue sourcing feedback from beta users (goal is 3, ideally covering both loading methods)
  • road to GA and certification
  • further improvements as we prepare for Postgres and MySQL V2

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

What’s been completed:

  • PR campaign via many tools to source more beta testers
  • identified additional improvements around error reporting and timeouts

📚 Learnings and hurdles:

  • refined our speed measurements which look good

🚫 Blockers:

  • waiting for 2 more beta testers to give us feedback

🌱 Looking ahead:

  • fix outstanding bugs
  • tentative timeline
    • 1st week of Jan - GA
    • middle of Jan - set up Redshift cost dashboard
    • Feb 1 - certification
    • Mar 1 - breaking change deadline

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

✅ What’s been completed:

  • ~3 more beta users gave feedback

📚 Learnings and hurdles:

  • OSS users need to select Raw data (JSON) as their Normalization method under the Transformation tab
  • beta users have helped us discover error cases to address

🚫 Blockers:

  • none

🌱 Looking ahead:

  • fix remaining bugs for GA
  • write up summary of beta program
  • tentative timeline
    • 2nd week of Jan - GA
    • 2nd half of Jan - set up Redshift cost dashboard
    • Feb 1 - certification
    • Mar 1 - breaking change deadline

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

✅ What’s been completed:

  • completed bug fixes/tasks for GA

📚 Learnings and hurdles:

🚫 Blockers:

  • none

🌱 Looking ahead:

  • 3 remaining bugs/tasks, aiming to GA this week
  • subsequent timeline
    • 2nd half of Jan - set up Redshift cost dashboard
    • Feb 1 - certification
    • Mar 1 - breaking change deadline

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

✅ What’s been completed:

  • bug fixes (1, 2)
  • GA code changes are ready

📚 Learnings and hurdles:

🚫 Blockers:

🌱 Looking ahead:

  • this week
    • one open bug
    • breaking change release doc
    • GA by end of week
  • then
    • 2nd half of Jan - set up Redshift cost dashboard
    • mid Feb - certification
    • mid March - breaking change deadline

@cynthiaxyin
Copy link
Contributor

Redshift Destinations V2 weekly update:

✅ What’s been completed:

📚 Learnings and hurdles:

🚫 Blockers:

  • n/a

🌱 Looking ahead:

  • Redshift cost dashboard
  • certification!
  • breaking change deadline March 15

@cynthiaxyin
Copy link
Contributor

onward to certification! airbytehq/airbyte-internal-issues#2386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic team/destinations Destinations team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants