Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS Fixes #59

Merged
merged 4 commits into from
Dec 10, 2024
Merged

APS Fixes #59

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82146d0
A couple of changes needed to get APS back to working order.
jonathansligh-nimbus Dec 4, 2024
7f78ab5
Fixing a weird issue.
jonathansligh-nimbus Dec 9, 2024
4fa8336
Moved testMode initializer to after creation of the helper.
jonathansligh-nimbus Dec 9, 2024
467925c
Added SKADN Ids to Sample App
jonathansligh-nimbus Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion com.adsbynimbus.nimbus/Runtime/Plugins/iOS/NimbusManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import NimbusRenderVideoKit
import NimbusKit
#if NIMBUS_ENABLE_APS
import NimbusRequestAPSKit
import DTBiOSSDK
#endif
#if NIMBUS_ENABLE_VUNGLE
import VungleAdsSDK
Expand Down Expand Up @@ -62,7 +63,8 @@ import NimbusSDK

#if NIMBUS_ENABLE_APS
@objc public class func initializeAPSRequestHelper(appKey: String, timeoutInSeconds: Double, enableTestMode: Bool) {
apsRequestHelper = NimbusAPSRequestHelper(appKey: appKey, timeoutInSeconds: timeoutInSeconds, enableTestMode: enableTestMode)
DTBAds.sharedInstance().testMode = enableTestMode
Copy link
Member

@JasonSznol JasonSznol Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably happen after the creation of the helper; not a blocker though.

apsRequestHelper = NimbusAPSRequestHelper(appKey: appKey, timeoutInSeconds: timeoutInSeconds)
}

@objc public class func addAPSSlot(slotUUID: String, width: Int, height: Int, isVideo: Bool) {
Expand Down
1 change: 1 addition & 0 deletions com.adsbynimbus.nimbus/Runtime/Scripts/Nimbus.Internal/IOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Runtime.InteropServices;
using Nimbus.Internal.Interceptor;
using Nimbus.Internal.Interceptor.ThirdPartyDemand.APS;
using Nimbus.Internal.Interceptor.ThirdPartyDemand.Vungle;
using Nimbus.ScriptableObjects;
using OpenRTB.Enumerations;
Expand Down
3 changes: 3 additions & 0 deletions com.adsbynimbus.nimbus/Runtime/Scripts/Nimbus.Tests/InterceptorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
using Nimbus.Internal;
using Nimbus.Internal.Interceptor;
using Nimbus.Internal.Interceptor.ThirdPartyDemand;
#if UNITY_IOS
using Nimbus.Internal.Interceptor.ThirdPartyDemand.APS;
#endif
using NUnit.Framework;
using OpenRTB.Request;

Expand Down