Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS Fixes #59

Merged
merged 4 commits into from
Dec 10, 2024
Merged

APS Fixes #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82146d0
A couple of changes needed to get APS back to working order.
jonathansligh-nimbus Dec 4, 2024
7f78ab5
Fixing a weird issue.
jonathansligh-nimbus Dec 9, 2024
4fa8336
Moved testMode initializer to after creation of the helper.
jonathansligh-nimbus Dec 9, 2024
467925c
Added SKADN Ids to Sample App
jonathansligh-nimbus Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.adsbynimbus.nimbus/Editor/SkaAdNetworkEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Nimbus.Editor {
public class SkaAdNetworkEditor : EditorWindow {
public const string SkaAdSavePath = "Packages/com.adsbynimbus.nimbus/Runtime/Plugins/iOS/SKAdNetworks";
public const string SkaAdSavePath = "Assets/Editor/SKAdNetworks";
public const string SkaKey = "SKAdNetworkItems";
public const string SkaItem = "SKAdNetworkIdentifier";

Expand Down
4 changes: 3 additions & 1 deletion com.adsbynimbus.nimbus/Runtime/Plugins/iOS/NimbusManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import NimbusRenderVideoKit
import NimbusKit
#if NIMBUS_ENABLE_APS
import NimbusRequestAPSKit
import DTBiOSSDK
#endif
#if NIMBUS_ENABLE_VUNGLE
import VungleAdsSDK
Expand Down Expand Up @@ -62,7 +63,8 @@ import NimbusSDK

#if NIMBUS_ENABLE_APS
@objc public class func initializeAPSRequestHelper(appKey: String, timeoutInSeconds: Double, enableTestMode: Bool) {
apsRequestHelper = NimbusAPSRequestHelper(appKey: appKey, timeoutInSeconds: timeoutInSeconds, enableTestMode: enableTestMode)
apsRequestHelper = NimbusAPSRequestHelper(appKey: appKey, timeoutInSeconds: timeoutInSeconds)
DTBAds.sharedInstance().testMode = enableTestMode
}

@objc public class func addAPSSlot(slotUUID: String, width: Int, height: Int, isVideo: Bool) {
Expand Down
1 change: 1 addition & 0 deletions com.adsbynimbus.nimbus/Runtime/Scripts/Nimbus.Internal/IOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Runtime.InteropServices;
using Nimbus.Internal.Interceptor;
using Nimbus.Internal.Interceptor.ThirdPartyDemand.APS;
using Nimbus.Internal.Interceptor.ThirdPartyDemand.Vungle;
using Nimbus.ScriptableObjects;
using OpenRTB.Enumerations;
Expand Down
3 changes: 3 additions & 0 deletions com.adsbynimbus.nimbus/Runtime/Scripts/Nimbus.Tests/InterceptorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
using Nimbus.Internal;
using Nimbus.Internal.Interceptor;
using Nimbus.Internal.Interceptor.ThirdPartyDemand;
#if UNITY_IOS
using Nimbus.Internal.Interceptor.ThirdPartyDemand.APS;
#endif
using NUnit.Framework;
using OpenRTB.Request;

Expand Down
50 changes: 50 additions & 0 deletions sample-app/Assets/Editor/SKAdNetworks
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
cstr6suwn9.skadnetwork
4fzdc2evr5.skadnetwork
4pfyvq9l8r.skadnetwork
2fnua5tdw4.skadnetwork
ydx93a7ass.skadnetwork
5a6flpkh64.skadnetwork
p78axxw29g.skadnetwork
v72qych5uu.skadnetwork
ludvb6z3bs.skadnetwork
cp8zw746q7.skadnetwork
c6k4g5qg8m.skadnetwork
s39g8k73mm.skadnetwork
3qy4746246.skadnetwork
3sh42y64q3.skadnetwork
f38h382jlk.skadnetwork
hs6bdukanm.skadnetwork
prcb7njmu6.skadnetwork
v4nxqhlyqp.skadnetwork
wzmmz9fp6w.skadnetwork
yclnxrl5pm.skadnetwork
t38b2kh725.skadnetwork
7ug5zh24hu.skadnetwork
9rd848q2bz.skadnetwork
y5ghdn5j9k.skadnetwork
n6fk4nfna4.skadnetwork
v9wttpbfk9.skadnetwork
n38lu8286q.skadnetwork
47vhws6wlr.skadnetwork
kbd757ywx3.skadnetwork
9t245vhmpl.skadnetwork
a2p9lx4jpn.skadnetwork
22mmun2rn5.skadnetwork
4468km3ulz.skadnetwork
2u9pt9hc89.skadnetwork
8s468mfl3y.skadnetwork
av6w8kgt66.skadnetwork
klf5c3l5u5.skadnetwork
ppxm28t8ap.skadnetwork
424m5254lk.skadnetwork
ecpz2srf59.skadnetwork
uw77j35x4d.skadnetwork
mlmmfzh3r3.skadnetwork
578prtvx9j.skadnetwork
4dzt52r2t5.skadnetwork
gta9lk7p23.skadnetwork
e5fvkxwrpn.skadnetwork
8c4e2ghe7u.skadnetwork
zq492l623r.skadnetwork
3rd42ekr43.skadnetwork
3qcr597p9d.skadnetwork