Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream 20-Dec-2024 #301

Merged
merged 18 commits into from
Dec 20, 2024

merge resolving conflict

faa5e9e
Select commit
Loading
Failed to load commit list.
Merged

Merge upstream 20-Dec-2024 #301

merge resolving conflict
faa5e9e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 20, 2024 in 0s

46.26% (-26.62%) compared to 5322ab6

View this Pull Request on Codecov

46.26% (-26.62%) compared to 5322ab6

Details

Codecov Report

Attention: Patch coverage is 9.25926% with 735 lines in your changes missing coverage. Please review.

Project coverage is 46.26%. Comparing base (5322ab6) to head (faa5e9e).

Files with missing lines Patch % Lines
...ngestion/source/kafka_connect/source_connectors.py 0.00% 227 Missing ⚠️
.../ingestion/source/kafka_connect/sink_connectors.py 0.00% 170 Missing ⚠️
...ub/ingestion/source/kafka_connect/kafka_connect.py 0.00% 157 Missing ⚠️
...c/datahub/ingestion/source/kafka_connect/common.py 0.00% 102 Missing ⚠️
...c/datahub/ingestion/source/looker/looker_common.py 0.00% 23 Missing ⚠️
...ion/src/datahub/sql_parsing/tool_meta_extractor.py 61.81% 21 Missing ⚠️
...c/datahub/ingestion/source/sql/mssql/job_models.py 0.00% 11 Missing ⚠️
...ahub/ingestion/source/looker/looker_lib_wrapper.py 0.00% 9 Missing ⚠️
...n/src/datahub/ingestion/source/sql/mssql/source.py 0.00% 6 Missing ⚠️
...c/datahub/ingestion/source/looker/looker_source.py 0.00% 4 Missing ⚠️
... and 4 more

❗ There is a different number of reports uploaded between BASE (5322ab6) and HEAD (faa5e9e). Click for more details.

HEAD has 49 uploads less than BASE
Flag BASE (5322ab6) HEAD (faa5e9e)
prefect 9 3
prefect- 9 0
dagster-3.10-dagster>=1.3.3 3 1
dagster-3.9-dagster>=1.3.3 3 1
gx-3.10-great-expectations~=0.16.0 numpy~=1.26.0 3 1
gx-3.8-great-expectations~=0.15.12 3 1
gx-3.11-great-expectations~=0.17.0 3 1
gx-3.11-great-expectations~=0.18.0 3 1
airflow-test-airflow23 3 1
airflow 6 2
pytest-testQuick 3 1
airflow-test-airflow24 3 1
2 0
pytest-testIntegrationBatch1 3 0
pytest-testIntegrationBatch0 4 0
pytest-testIntegrationBatch2 3 0
Additional details and impacted files
Files with missing lines Coverage Δ
...datahub_dagster_plugin/client/dagster_generator.py 57.89% <ø> (ø)
...gestion/src/datahub/configuration/source_common.py 100.00% <100.00%> (ø)
...on/src/datahub/ingestion/source/iceberg/iceberg.py 89.56% <100.00%> (-5.39%) ⬇️
...datahub/ingestion/source/iceberg/iceberg_common.py 87.09% <100.00%> (-10.73%) ⬇️
...a-ingestion/src/datahub/ingestion/source/mlflow.py 77.16% <100.00%> (-22.84%) ⬇️
...ion/src/datahub/ingestion/source/powerbi/config.py 91.47% <100.00%> (-7.00%) ⬇️
...n/source/powerbi/dataplatform_instance_resolver.py 73.07% <100.00%> (-26.93%) ⬇️
...ngestion/source/powerbi/m_query/pattern_handler.py 38.51% <100.00%> (-50.98%) ⬇️
...datahub/ingestion/source/snowflake/snowflake_v2.py 62.84% <ø> (-26.05%) ⬇️
...tahub/ingestion/source/tableau/tableau_constant.py 100.00% <100.00%> (ø)
... and 15 more

... and 365 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5322ab6...faa5e9e. Read the comment docs.

View more details on Codecov