Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream 20-Dec-2024 #301

Merged
merged 18 commits into from
Dec 20, 2024
Merged

Merge upstream 20-Dec-2024 #301

merged 18 commits into from
Dec 20, 2024

Conversation

anshbansal
Copy link
Collaborator

…b-project#12158)## Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

david-leifker and others added 18 commits December 18, 2024 12:45
Copy link

Hello @anshbansal 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 73.40619% with 292 lines in your changes missing coverage. Please review.

Project coverage is 59.11%. Comparing base (5322ab6) to head (faa5e9e).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
.../ingestion/source/kafka_connect/sink_connectors.py 64.11% 61 Missing ⚠️
...ngestion/source/kafka_connect/source_connectors.py 81.05% 43 Missing ⚠️
...ion/src/datahub/sql_parsing/tool_meta_extractor.py 61.81% 21 Missing ⚠️
...ahubproject/metadata/context/OperationContext.java 44.44% 18 Missing and 2 partials ⚠️
...ub/ingestion/source/kafka_connect/kafka_connect.py 92.35% 12 Missing ⚠️
...t/test/metadata/context/TestOperationContexts.java 57.69% 9 Missing and 2 partials ⚠️
...bproject/openapi/operations/test/IdController.java 0.00% 11 Missing ⚠️
.../com/linkedin/metadata/entity/SearchRetriever.java 0.00% 7 Missing ⚠️
...linkedin/metadata/entity/ebean/EbeanAspectDao.java 85.36% 4 Missing and 2 partials ⚠️
...graphql/types/mlmodel/mappers/MLFeatureMapper.java 0.00% 5 Missing ⚠️
... and 36 more

❗ There is a different number of reports uploaded between BASE (5322ab6) and HEAD (faa5e9e). Click for more details.

HEAD has 45 uploads less than BASE
Flag BASE (5322ab6) HEAD (faa5e9e)
prefect 9 3
prefect- 9 0
dagster-3.10-dagster>=1.3.3 3 1
dagster-3.9-dagster>=1.3.3 3 1
gx-3.10-great-expectations~=0.16.0 numpy~=1.26.0 3 1
gx-3.8-great-expectations~=0.15.12 3 1
gx-3.11-great-expectations~=0.17.0 3 1
gx-3.11-great-expectations~=0.18.0 3 1
airflow-test-airflow23 3 1
airflow 6 2
pytest-testQuick 3 1
airflow-test-airflow24 3 1
2 1
pytest-testIntegrationBatch1 3 1
pytest-testIntegrationBatch0 4 1
pytest-testIntegrationBatch2 3 1
Additional details and impacted files
Files with missing lines Coverage Δ
datahub-frontend/app/auth/AuthModule.java 83.01% <100.00%> (ø)
...din/datahub/upgrade/config/SystemUpdateConfig.java 90.69% <100.00%> (ø)
...nkedin/datahub/upgrade/system/AbstractMCLStep.java 79.56% <100.00%> (ø)
...upgrade/system/bootstrapmcps/BootstrapMCPUtil.java 73.91% <100.00%> (ø)
...src/main/java/com/linkedin/metadata/Constants.java 0.00% <ø> (ø)
...datahub_dagster_plugin/client/dagster_generator.py 57.89% <ø> (ø)
...gestion/src/datahub/configuration/source_common.py 100.00% <100.00%> (ø)
...on/src/datahub/ingestion/source/iceberg/iceberg.py 96.95% <100.00%> (+2.00%) ⬆️
...datahub/ingestion/source/iceberg/iceberg_common.py 98.92% <100.00%> (+1.09%) ⬆️
...c/datahub/ingestion/source/looker/looker_source.py 79.44% <100.00%> (+1.32%) ⬆️
... and 70 more

... and 1224 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5322ab6...faa5e9e. Read the comment docs.

@anshbansal anshbansal merged commit 2ab473f into master Dec 20, 2024
51 of 54 checks passed
@anshbansal anshbansal deleted the ab-merge-upstream-2024-12-20 branch December 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants