ci: throw error on wrong tag instead of skipping #299
Conversation
|
Hello @anshbansal 😄 Thank you so much for opening a pull request!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
actionlint
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2034:warning:2:1: SHORT_SHA appears unused. Verify use (or export if used externally) [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:3:7: See if you can use ${variable//search/replace} instead [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2034:warning:2:1: SHORT_SHA appears unused. Verify use (or export if used externally) [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2034:warning:2:1: SHORT_SHA appears unused. Verify use (or export if used externally) [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:3:7: See if you can use ${variable//search/replace} instead [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting [shellcheck]
| - name: Validate ref format | ||
| run: | | ||
| source .github/scripts/docker_helpers.sh | ||
| validate_github_ref_for_python_tag | ||
| - name: Compute Tag | ||
| id: tag | ||
| run: | |
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:4:20: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:43: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2034:warning:2:1: SHORT_SHA appears unused. Verify use (or export if used externally) [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2001:style:3:19: See if you can use ${variable//search/replace} instead [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:24: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:4:44: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
the runner of "docker/login-action@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
the runner of "docker/build-push-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:17: Double quote to prevent globbing and word splitting [shellcheck]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
=============================================
- Coverage 87.10% 38.42% -48.69%
- Complexity 0 4886 +4886
=============================================
Files 3 1258 +1255
Lines 287 52090 +51803
Branches 0 4293 +4293
=============================================
+ Hits 250 20017 +19767
- Misses 37 30557 +30520
- Partials 0 1516 +1516 📢 Thoughts on this report? Let us know! |
In case it just skips it can get confusing unless you know where to look. This makes the error obvious.
Checklist