ci: throw error on wrong tag instead of skipping

acryldata · Dec 12, 2024 · a324bc7 · a324bc7
1 parent 272c1ad
commit a324bc7
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 6 deletions.
diff --git a/.github/scripts/docker_helpers.sh b/.github/scripts/docker_helpers.sh
@@ -46,3 +46,11 @@ function get_platforms_based_on_branch {
         echo "linux/amd64"
     fi
 }
+
+function validate_github_ref_for_python_tag {
+    if [[ ! "$GITHUB_REF" =~ ^refs/tags/v ]]; then
+        echo "Error: This workflow must be triggered by a tag starting with 'v'"
+        echo "Current GITHUB_REF: $GITHUB_REF"
+        exit 1
+    fi
+}
diff --git a/.github/workflows/docker-airflow-acryl.yml b/.github/workflows/docker-airflow-acryl.yml
@@ -7,7 +7,6 @@ on:
 
 jobs:
   setup:
-    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
@@ -16,6 +15,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+      - name: Validate ref format
+        run: |
+          source .github/scripts/docker_helpers.sh
+          validate_github_ref_for_python_tag
       - name: Compute Tag
         id: tag
         run: |

diff --git a/.github/workflows/publish-airflow-plugin-pypi-release.yml b/.github/workflows/publish-airflow-plugin-pypi-release.yml
@@ -6,13 +6,16 @@ on:
 
 jobs:
   setup:
-    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+      - name: Validate ref format
+        run: |
+          source .github/scripts/docker_helpers.sh
+          validate_github_ref_for_python_tag
       - name: Compute Tag
         id: tag
         run: |

diff --git a/.github/workflows/publish-dagster-plugin-pypi-release.yml b/.github/workflows/publish-dagster-plugin-pypi-release.yml
@@ -6,13 +6,16 @@ on:
 
 jobs:
   setup:
-    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+      - name: Validate ref format
+        run: |
+          source .github/scripts/docker_helpers.sh
+          validate_github_ref_for_python_tag
       - name: Compute Tag
         id: tag
         run: |

diff --git a/.github/workflows/publish-datahub-jars.yml b/.github/workflows/publish-datahub-jars.yml
@@ -30,13 +30,16 @@ jobs:
           echo "Enable publish: ${{ env.SIGNING_KEY != '' }}"
           echo "publish=${{ env.SIGNING_KEY != '' }}" >> $GITHUB_OUTPUT
   setup:
-    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
     steps:
       - name: Checkout
         uses: acryldata/sane-checkout-action@v3
+      - name: Validate ref format
+        run: |
+          source .github/scripts/docker_helpers.sh
+          validate_github_ref_for_python_tag
       - name: Compute Tag
         id: tag
         run: |

diff --git a/.github/workflows/publish-gx-plugin-pypi-release.yml b/.github/workflows/publish-gx-plugin-pypi-release.yml
@@ -6,13 +6,16 @@ on:
 
 jobs:
   setup:
-    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+      - name: Validate ref format
+        run: |
+          source .github/scripts/docker_helpers.sh
+          validate_github_ref_for_python_tag
       - name: Compute Tag
         id: tag
         run: |

diff --git a/.github/workflows/publish-pypi-release.yml b/.github/workflows/publish-pypi-release.yml
@@ -6,13 +6,16 @@ on:
 
 jobs:
   setup:
-    if: startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     outputs:
       tag: ${{ steps.tag.outputs.tag }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+      - name: Validate ref format
+        run: |
+          source .github/scripts/docker_helpers.sh
+          validate_github_ref_for_python_tag
       - name: Compute Tag
         id: tag
         run: |