Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL updates #48

Merged
merged 4 commits into from
Oct 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Options:

$ fb web [options]

Launch web-applcation which is task-manager. This command has more opportunities then `start`. Web-application read `Procfile` and `package.json` together and adding ability switching between them
Launch web-application which is task-manager. This command has more opportunities then `start`. Web-application read `Procfile` and `package.json` together and adding ability switching between them

Options:
- `-t, --tasks [tasks]` - list of tasks which will be managing in the `fb web` command ( example : `fb web --tasks start,start:dev,start-server` and this tasks will be showing in the web-application `start`,`start:dev`,`start-server` )
Expand Down
4 changes: 2 additions & 2 deletions lib/processWorker.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const emitter = require('./emitter')
const _ = require('lodash')
const prog = require('child_process')
const ws = require('./ws')
var colors = require('colors')
let colors = require('colors')
colors.enabled = true
const kill = require('tree-kill')
const storage = require('./storage')
Expand Down Expand Up @@ -50,7 +50,7 @@ function updateTask(name, { isRun, isStartRunning, isStopping, log }) {
}

function pushLog(name, rawLog, isEnded) {
var log = rawLog.toString()
let log = rawLog.toString()
updateTask(name, { isRun: !isEnded, log })
}

Expand Down
2 changes: 1 addition & 1 deletion lib/server.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var express = require('express')
const express = require('express')
const bodyParser = require('body-parser')
const http = require('http')
const opn = require('opn')
Expand Down
4 changes: 2 additions & 2 deletions lib/ws.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ const WebSocket = require('ws')
const _ = require('lodash')

let connections = {}
var connectionIDCounter = 0
let connectionIDCounter = 0

function create(server) {
const ws = new WebSocket.Server({ server })
ws.on('connection', wc => {
wc.send(JSON.stringify({ status: 'ok' }))
var connection = wc
let connection = wc
// Store a reference to the connection using an incrementing ID
connection.id = connectionIDCounter++
connections[connection.id] = connection
Expand Down
Loading