QoL updates #48
QoL updates #48
Conversation
added webpack peer dependency so it loads automatically, critical vulnerability found in deep dependency of css-loader 0.28.11, updated to next (latest) version. https://www.npmjs.com/advisories?search=macaddress&version=0.2.8
|
Hi @karnthis ! |
| @@ -67,13 +67,14 @@ | |||
| "prettier": "1.10.2", | |||
| "style-loader": "0.21.0", | |||
| "webpack": "4.8.2", | |||
| "webpack-cli": "2.1.3" | |||
| "webpack-cli": "2.1.3", | |||
| "ajv": "^6.0.0" | |||
There was a problem hiding this comment.
@karnthis You added this dependency but not use it
It's for the future? validating package.json yep?
There was a problem hiding this comment.
the ajv ^6.0.0 dependency was added because webpack throws a peer dependency error for ajv-keywords, even though ajv is included by webpack by default. functionally there should be little change other than perhaps duplication of the ajv module files, but this silences the error and reduces user confusion.
There was a problem hiding this comment.
this is the error delivered without the dependency added
npm WARN [email protected] requires a peer of ajv@^6.0.0 but none is installed. You must install peer dependencies yourself.
note: I do not have webpack pre-installed globally, but I suspect that users with it already installed would be unlikely to see this warning
| @@ -54,7 +54,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "babel-eslint": "8.2.1", | |||
| "css-loader": "0.28.11", | |||
| "css-loader": "1.0.0", | |||
forked to work on issues, addresses a number of small things before starting work. includes typo fixes, updating vars to const/let, updated version to 1.8.5, and addresses dependency issues.