Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mainnet Fork Tests #416

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Add Mainnet Fork Tests #416

merged 13 commits into from
Sep 12, 2024

Conversation

CheyenneAtapour
Copy link
Contributor

Adds mainnet fork tests to Steward CCIP Extension

@height Height
Copy link

height bot commented Aug 23, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@CheyenneAtapour CheyenneAtapour changed the base branch from main to feat/ccip-extension August 23, 2024 02:44
miguelmtzinf
miguelmtzinf reviewed Aug 23, 2024
View reviewed changes
src/test/TestGhoStewards.t.sol Outdated
assertEq(currentSupplyCap, 0);
uint256 newSupplyCap = currentSupplyCap + 1;
// Can't update supply cap even by 1 since it's 0, and 100% of 0 is 0
vm.expectRevert('INVALID_SUPPLY_CAP_UPDATE');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisit spec

@miguelmtzinf miguelmtzinf marked this pull request as ready for review September 12, 2024 16:24
@miguelmtzinf miguelmtzinf merged commit 4e645f6 into feat/ccip-extension Sep 12, 2024
1 check passed
@miguelmtzinf miguelmtzinf deleted the fork-tests branch September 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelmtzinf miguelmtzinf miguelmtzinf left review comments

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CheyenneAtapour @miguelmtzinf