test: add fork tests (#416)

* test: role setup * test: add basic fork tests * fix: requested changes * fix: use aave address book * fix: Update aave address book dep * test: Add arbitrum tests * test: Add rate limit tests * test: Add gho borrow rate tests * fix: Use appropriate controlled facilitator * fix: remove unused import * fix: Add arbitrum env var to ci --------- Co-authored-by: miguelmtzinf <[email protected]>
aave · Sep 12, 2024 · 4e645f6 · 4e645f6
1 parent fe72684
commit 4e645f6
Show file tree

Hide file tree

Showing 10 changed files with 818 additions and 88 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -8,6 +8,7 @@ jobs:
       ALCHEMY_KEY: '${{secrets.ALCHEMY_KEY}}'
       ETH_RPC_URL: 'https://eth-mainnet.g.alchemy.com/v2/${{secrets.ALCHEMY_KEY}}'
       RPC_MAINNET: 'https://eth-mainnet.g.alchemy.com/v2/${{secrets.ALCHEMY_KEY}}'
+      RPC_ARBITRUM: 'https://arb-mainnet.g.alchemy.com/v2/${{secrets.ALCHEMY_KEY}}'
     strategy:
       matrix:
         node-version:

diff --git a/foundry.toml b/foundry.toml
@@ -14,5 +14,6 @@ optimizer_runs = 200
 
 [rpc_endpoints]
 mainnet = "${RPC_MAINNET}" 
+arbitrum = "${RPC_ARBITRUM}"
 
 # See more config options https://github.com/foundry-rs/foundry/tree/master/config
diff --git a/lib/aave-address-book b/lib/aave-address-book
diff --git a/src/contracts/misc/dependencies/Ccip.sol b/src/contracts/misc/dependencies/Ccip.sol
@@ -196,6 +196,14 @@ interface IUpgradeableLockReleaseTokenPool {
     RateLimiter.Config memory inboundConfig
   ) external;
 
+  function setRateLimitAdmin(address rateLimitAdmin) external;
+
+  function setBridgeLimitAdmin(address bridgeLimitAdmin) external;
+
+  function getRateLimitAdmin() external view returns (address);
+
+  function getBridgeLimitAdmin() external view returns (address);
+
   function getBridgeLimit() external view returns (uint256);
 
   function getCurrentOutboundRateLimiterState(

diff --git a/src/test/TestGhoBase.t.sol b/src/test/TestGhoBase.t.sol
@@ -43,7 +43,6 @@ import {IGhoVariableDebtTokenTransferHook} from 'aave-stk-v1-5/src/interfaces/IG
 import {IPool} from '@aave/core-v3/contracts/interfaces/IPool.sol';
 import {IPoolAddressesProvider} from '@aave/core-v3/contracts/interfaces/IPoolAddressesProvider.sol';
 import {IStakedAaveV3} from 'aave-stk-v1-5/src/interfaces/IStakedAaveV3.sol';
-import {IFixedRateStrategyFactory} from '../contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol';
 
 // non-GHO contracts
 import {AdminUpgradeabilityProxy} from '@aave/core-v3/contracts/dependencies/openzeppelin/upgradeability/AdminUpgradeabilityProxy.sol';
@@ -80,7 +79,7 @@ import {SampleSwapFreezer} from '../contracts/facilitators/gsm/misc/SampleSwapFr
 import {GsmRegistry} from '../contracts/facilitators/gsm/misc/GsmRegistry.sol';
 import {IGhoGsmSteward} from '../contracts/misc/interfaces/IGhoGsmSteward.sol';
 import {GhoGsmSteward} from '../contracts/misc/GhoGsmSteward.sol';
-import {FixedFeeStrategyFactory} from 'src/contracts/facilitators/gsm/feeStrategy/FixedFeeStrategyFactory.sol';
+import {FixedFeeStrategyFactory} from '../contracts/facilitators/gsm/feeStrategy/FixedFeeStrategyFactory.sol';
 
 // CCIP contracts
 import {MockUpgradeableLockReleaseTokenPool} from './mocks/MockUpgradeableLockReleaseTokenPool.sol';

diff --git a/src/test/TestGhoCcipSteward.t.sol b/src/test/TestGhoCcipSteward.t.sol
@@ -2,7 +2,7 @@
 pragma solidity ^0.8.0;
 
 import './TestGhoBase.t.sol';
-import {RateLimiter} from 'src/contracts/misc/dependencies/Ccip.sol';
+import {RateLimiter} from '../contracts/misc/dependencies/Ccip.sol';
 
 contract TestGhoCcipSteward is TestGhoBase {
   RateLimiter.Config rateLimitConfig =

diff --git a/src/test/TestGhoStewards.t.sol b/src/test/TestGhoStewards.t.sol