Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend AIP text #4

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Amend AIP text #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f653e9
fix: Make new impl constant
miguelmtzinf Dec 6, 2023
afec214
fix: Fix AIP text
miguelmtzinf Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...thereum_GhoIncidentReport_20231126/AaveV3Ethereum_GhoIncidentReport_20231113.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This proposal patches the GHO integration with the Aave V3 Pool, fixing an issue

## Motivation

A resolution for the identified technical issue identified in the GHO integration with the Aave V3 Ethereum Pool. The patch guarantees a permanent solution without altering any of the existing GHO features within the Aave Pool.
The proposed patch guarantees a permanent solution for the technical issue that was identified and reported by Immunefi with the GHO integration with the Aave V3 Ethereum Pool. The fix will be implemented without altering any of the existing GHO features within the Aave V3 Pool.

## Specification

Expand Down
6 changes: 2 additions & 4 deletions ...AaveV3Ethereum_GhoIncidentReport_20231126/AaveV3Ethereum_GhoIncidentReport_20231113.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ contract DeployEthereum is EthereumScript {

function run() external broadcast {
// deploy payloads
AaveV3Ethereum_GhoIncidentReport_20231113 payload = new AaveV3Ethereum_GhoIncidentReport_20231113(
NEW_VGHO_IMPL
);
AaveV3Ethereum_GhoIncidentReport_20231113 payload = new AaveV3Ethereum_GhoIncidentReport_20231113();

// compose action
IPayloadsControllerCore.ExecutionAction[]
Expand Down Expand Up @@ -47,7 +45,7 @@ contract CreateProposal is EthereumScript {
// create proposal
vm.startBroadcast();
GovV3Helpers.createProposal2_5(
vm,
vm,
payloads,
GovV3Helpers.ipfsHashFile(
vm,
Expand Down
6 changes: 1 addition & 5 deletions ...7_AaveV3Ethereum_GhoIncidentReport_20231126/AaveV3Ethereum_GhoIncidentReport_20231113.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@ import {AaveV3Ethereum, AaveV3EthereumAssets} from 'aave-address-book/AaveV3Ethe
* - Discussion: https://governance.aave.com/t/arfc-gho-technical-incident-13-11-2023/15642
*/
contract AaveV3Ethereum_GhoIncidentReport_20231113 {
address public immutable NEW_VGHO_IMPL;

constructor(address newVGhoImpl) {
NEW_VGHO_IMPL = newVGhoImpl;
}
address public constant NEW_VGHO_IMPL = 0x20Cb2f303EDe313e2Cc44549Ad8653a5E8c0050e;

function execute() external {
AaveV3Ethereum.POOL_CONFIGURATOR.updateVariableDebtToken(
Expand Down
2 changes: 1 addition & 1 deletion ...AaveV3Ethereum_GhoIncidentReport_20231126/AaveV3Ethereum_GhoIncidentReport_20231113.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ contract AaveV3Ethereum_GhoIncidentReport_20231113_Test is ProtocolV3TestBase {

function setUp() public {
vm.createSelectFork(vm.rpcUrl('mainnet'), 18722500);
proposal = new AaveV3Ethereum_GhoIncidentReport_20231113(NEW_VGHO_IMPL);
proposal = new AaveV3Ethereum_GhoIncidentReport_20231113();
}

function test_defaultProposalExecution() public {
Expand Down