Amend AIP text #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Foundry report forge 0.2.0 (fdad9fb 2023-12-06T00:17:27.061170607Z)Build logCompiling 291 files with 0.8.19
Solc 0.8.19 finished in 158.90s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
--> lib/aave-helpers/src/GovV3Helpers.sol:775:5:
|
775 | address votingPortal
| ^^^^^^^^^^^^^^^^^^^^
Warning (2072): Unused local variable.
--> src/20231122_AaveV3Harmony_FreezePriceFeedsOnV3Harmony/FreezePriceFeedsOnV3Harmony_20231122.s.sol:16:5:
|
16 | AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122 payload0 = new AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| Contract | Size (kB) | Margin (kB) |
|-----------------------------------------------------------------------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.086 | 24.49 |
| AaveSafetyModule | 0.086 | 24.49 |
| AaveSwapper | 5.613 | 18.963 |
| AaveV1Ethereum_FixedREPPriceFeed_20231031 | 0.706 | 23.87 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2AvalancheAssets | 0.086 | 24.49 |
| AaveV2Avalanche_IncreaseStablecoinOptimalBorrowRates_20231113 | 1.899 | 22.677 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumAMMAssets | 0.086 | 24.49 |
| AaveV2EthereumAssets | 0.086 | 24.49 |
| AaveV2Ethereum_AaveV2EthereumLTReduction_20231030 | 3.023 | 21.553 |
| AaveV2Ethereum_Disable_Stable_Borrows_20231104 | 2.519 | 22.057 |
| AaveV2Ethereum_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.078 | 21.498 |
| AaveV2Ethereum_V2DeprecationPlan20231120_20231121 | 2.003 | 22.573 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV2PolygonAssets | 0.086 | 24.49 |
| AaveV2Polygon_AaveFundingUpdates_20231102 | 1.627 | 22.949 |
| AaveV2Polygon_IncreaseStablecoinOptimalBorrowRates_20231113 | 1.899 | 22.677 |
| AaveV2Polygon_ReserveFactorUpdatesPolygonAaveV2_20231103 | 1.01 | 23.566 |
| AaveV2Polygon_ReserveFactorUpdatesPolygonAaveV2_20231124 | 1.01 | 23.566 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumAssets | 0.086 | 24.49 |
| AaveV3ArbitrumEModes | 0.086 | 24.49 |
| AaveV3Arbitrum_Disable_Stable_Borrows_20231104 | 4.14 | 20.436 |
| AaveV3Arbitrum_IncreaseStablecoinOptimalBorrowRates_20231113 | 5.167 | 19.409 |
| AaveV3Arbitrum_MAIMIMATICDeprecation20231031_20231031 | 4.227 | 20.349 |
| AaveV3Arbitrum_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3AvalancheAssets | 0.086 | 24.49 |
| AaveV3AvalancheEModes | 0.086 | 24.49 |
| AaveV3Avalanche_Disable_Stable_Borrows_20231104 | 3.471 | 21.105 |
| AaveV3Avalanche_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.665 | 19.911 |
| AaveV3Avalanche_MAIMIMATICDeprecation20231031_20231031 | 4.364 | 20.212 |
| AaveV3Base | 0.086 | 24.49 |
| AaveV3BaseAssets | 0.086 | 24.49 |
| AaveV3BaseEModes | 0.086 | 24.49 |
| AaveV3Base_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.667 | 20.909 |
| AaveV3Base_OnboardingWstETHToAaveV3OnBaseNetwork_20231127 | 5.044 | 19.532 |
| AaveV3Base_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Ethereum | 0.086 | 24.49 |
| AaveV3EthereumAssets | 0.086 | 24.49 |
| AaveV3EthereumEModes | 0.086 | 24.49 |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682 | 23.894 |
| AaveV3Ethereum_AaveFundingUpdates_20231102 | 5.809 | 18.767 |
| AaveV3Ethereum_AddFXSToEthereumV3_20231108 | 4.996 | 19.58 |
| AaveV3Ethereum_AmendSafetyModuleAAVEEmissions_20231104 | 1.938 | 22.638 |
| AaveV3Ethereum_CRVUSDOnboardingOnAaveV3Ethereum_20231116 | 4.996 | 19.58 |
| AaveV3Ethereum_ChaosLabsRiskManagementRenewal_20231101 | 1.014 | 23.562 |
| AaveV3Ethereum_ChaosLabsRiskParameterUpdatesIncreaseMKRDebtCeilingOnV3Ethereum_20231116 | 3.418 | 21.158 |
| AaveV3Ethereum_GHOIncreaseBorrowRate_20231108 | 0.326 | 24.25 |
| AaveV3Ethereum_GHO_Incident_Report_20231122 | 0.385 | 24.191 |
| AaveV3Ethereum_GauntletAaveRenewal2023_20231128 | 1.232 | 23.344 |
| AaveV3Ethereum_GhoIncidentReport_20231113 | 1.098 | 23.478 |
| AaveV3Ethereum_IncreaseGHOBorrowRate_20231121 | 0.326 | 24.25 |
| AaveV3Ethereum_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.417 | 20.159 |
| AaveV3Ethereum_TokenLogicFunding_20231114 | 0.423 | 24.153 |
| AaveV3Ethereum_TreasuryManagementAddToRETHHolding_20231103 | 1.928 | 22.648 |
| AaveV3Ethereum_UpgradeAaveV3ETHPooolWETHParameters_20231031 | 3.671 | 20.905 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomAssets | 0.086 | 24.49 |
| AaveV3FantomEModes | 0.086 | 24.49 |
| AaveV3Gnosis | 0.086 | 24.49 |
| AaveV3GnosisAssets | 0.086 | 24.49 |
| AaveV3GnosisEModes | 0.086 | 24.49 |
| AaveV3Gnosis_AaveV3GnosisActivation_20231026 | 8.802 | 15.774 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3HarmonyAssets | 0.086 | 24.49 |
| AaveV3HarmonyEModes | 0.086 | 24.49 |
| AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122 | 3.097 | 21.479 |
| AaveV3Metis | 0.086 | 24.49 |
| AaveV3MetisAssets | 0.086 | 24.49 |
| AaveV3MetisEModes | 0.086 | 24.49 |
| AaveV3Metis_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.914 | 20.662 |
| AaveV3Metis_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismAssets | 0.086 | 24.49 |
| AaveV3OptimismEModes | 0.086 | 24.49 |
| AaveV3Optimism_Disable_Stable_Borrows_20231104 | 3.851 | 20.725 |
| AaveV3Optimism_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.919 | 19.657 |
| AaveV3Optimism_MAIMIMATICDeprecation20231031_20231031 | 4.228 | 20.348 |
| AaveV3Optimism_OnboardNativeUSDCToAaveV3Optimism_20231122 | 5.551 | 19.025 |
| AaveV3Optimism_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonAssets | 0.086 | 24.49 |
| AaveV3PolygonEModes | 0.086 | 24.49 |
| AaveV3Polygon_ChaosLabsCRVAaveV3PolygonLTReduction_20231106 | 3.416 | 21.16 |
| AaveV3Polygon_Disable_Stable_Borrows_20231104 | 4.139 | 20.437 |
| AaveV3Polygon_GauntletCapRecommendationsForPolygonV3_20231120 | 3.392 | 21.184 |
| AaveV3Polygon_GauntletRecommendationToLowerStMATICMaticXNonEmodeLTPt2_20231117 | 3.571 | 21.005 |
| AaveV3Polygon_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.416 | 20.16 |
| AaveV3Polygon_MAIMIMATICDeprecation20231031_20231031 | 4.226 | 20.35 |
| AaveV3Polygon_WMATICInterestRateUpdate_20231112 | 3.662 | 20.914 |
| Address | 0.086 | 24.49 |
| ChainHelpers | 0.086 | 24.49 |
| ChainIds | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| Create2Utils | 0.164 | 24.412 |
| DataTypes | 0.086 | 24.49 |
| EngineFlags | 0.086 | 24.49 |
| Errors | 4.714 | 19.862 |
| GovHelpers | 0.086 | 24.49 |
| GovV3Helpers | 2.664 | 21.912 |
| GovV3StorageHelpers | 0.086 | 24.49 |
| GovernanceV3Arbitrum | 0.086 | 24.49 |
| GovernanceV3Avalanche | 0.086 | 24.49 |
| GovernanceV3BNB | 0.086 | 24.49 |
| GovernanceV3Base | 0.086 | 24.49 |
| GovernanceV3Ethereum | 0.086 | 24.49 |
| GovernanceV3Gnosis | 0.086 | 24.49 |
| GovernanceV3Metis | 0.086 | 24.49 |
| GovernanceV3Optimism | 0.086 | 24.49 |
| GovernanceV3Polygon | 0.086 | 24.49 |
| HelperStructs | 0.086 | 24.49 |
| IpfsUtils | 0.086 | 24.49 |
| MiscEthereum | 0.086 | 24.49 |
| MiscPolygon | 0.086 | 24.49 |
| MockExecutor | 0.437 | 24.139 |
| PayloadsControllerUtils | 0.086 | 24.49 |
| ProxyHelpers | 0.086 | 24.49 |
| ReserveConfiguration | 0.171 | 24.405 |
| SafeERC20 | 0.086 | 24.49 |
| StdStyle | 0.086 | 24.49 |
| StorageHelpers | 0.086 | 24.49 |
| WadRayMath | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| mock_proposal | 3.653 | 20.923 |
| safeconsole | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 |Test success 🌈 |
miguelmtzinf
added a commit
that referenced
this pull request
Dec 13, 2023
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) --------- Co-authored-by: Parth Patel <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jan 24, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: added stkgho initialization proposal * feat: fixed proposal description * feat: removed submodule * feat: fixed deployment script * feat: replaced duration calculation * git commit remove submodule * feat: fixed payload build function * update proposal * sync branch * fix: variable name * fix: Fix AIP payload * fix: Fix tests * test: added further test on emission per day * refactor: removed unused constants * fix: catapulta commands * fix: Add fixes to payload * fix: Rebuild proposal with autogenerate tool --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: miguelmtzinf <[email protected]> Co-authored-by: miguelmtz <[email protected]> Co-authored-by: Mark Hinschberger <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jan 24, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add payload * test: Add tests * feat: Add script and tests with final addresses * fix: Fix link and gasLimit amounts * fix: Update dependencies * fix: Fix oracle swap freezer addresses * fix: Bump block number for tests * fix: Reduce LINK amount so its enough in treasury * add test for OracleSwapFreezer * fix: Clean up in tests * docs: Add AIP text * docs: Fix typo in natspec docs Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix typo on natspec docs Co-authored-by: Harsh Pandey <[email protected]> * docs: Fix typo in natspec docs * fix: Add DAO as swap freezer --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: Harsh Pandey <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jun 17, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add AIP code * fix: Fix AIP docs and imports * fix: Remove unnecesary test * fix: Updates risk params * test: Add ccip e2e tests * fix: Fix Arbitrum payload max bytecode size exceeded * feat: Add sophisticated defensive aave seed (#13) * feat: Add sophhisticated defensive aave seed * fix: Allows AaveDefensive contract remove itself as facilitator * fix: Add docs and reduce bytecode size * fix: Reduce Utils lib bytecode size * fix: Fix error in Utils * fix: Add Capped gho usd price oracle * fix: Add AIP draft text * fix: Update block number for tests * fix: Remove unneeded files * fix: Install latest version of gho and ccip repos * fix: Remove unused helper function * fix: Fix AIP text * fix: Remove defensive and use create2 * fix: Add fixed price oracle * fix: Remove unnecessary memory variables * fix: Use create1 and move listing out * fix: Remove listing aip --------- Co-authored-by: Parth Patel <[email protected]>
CheyenneAtapour
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * fix: Fix AIP text --------- Co-authored-by: Parth Patel <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jun 26, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add proposal to onboard GHO * fix: Fix AIP name * fix: Update GHO ir * fix: Fix diff report * fix: Fix typo in AIP text Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix typo in AIP text Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix tests * fix: Fix lint --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: Harsh Pandey <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jul 30, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * initial upload: proposal template and fund stream * test: add stream withdraw test * docs: add summary and specs of AIP * test: add fuzz and insufficient funds tests * test: fuzz by seconds instead of days * fix: test changes as per pr comments * fix: comment typo * fix: discussion links, deal funds directly in tests * feat: update proposal doc * fix: doc header and formatting * fix: replace arfc with aip * fix: Fix typo in AIP text Co-authored-by: sendra <[email protected]> * feat: initial upload of template * feat: initial upload doc * fix: aip not arfc * fix: Updates lib * fix: Fix AIP text --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: miguelmtzinf <[email protected]> Co-authored-by: miguelmtz <[email protected]> Co-authored-by: sendra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.