Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single text node as browser title to fix warning #325

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Single text node as browser title to fix warning #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/PageLayout/PageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,14 @@ const seminarTitle: Record<Seminar, string> = {
// ked budeme potrebovat top-level stranky ako `/ina-stranka`, budeme musiet upravit, ako sa pracuje s `useSeminarInfo`
export const PageLayout: FC<PageLayoutProps> = ({contentWidth = 2, title = '', children}) => {
const {seminar} = useSeminarInfo()
const browserTitlePrefix = title && `${title} | `
const browserTitle = `${browserTitlePrefix}${seminarTitle[seminar]}`

return (
<>
<Head>
<title>
{title && `${title} | `}
{seminarTitle[seminar]}
</title>
{/* mali sme tu pred zmenou warning, musi to byt jeden text child: `A title element received an array with more than 1 element as children.` */}
<title>{browserTitle}</title>
</Head>
<PageTitleContainer.Provider initialState={title}>
<BannerContainer.Provider>
Expand Down
Loading