Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single text node as browser title to fix warning #325

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Single text node as browser title to fix warning #325

merged 1 commit into from
Apr 12, 2024

Conversation

rtrembecky
Copy link
Collaborator

@rtrembecky rtrembecky commented Jan 2, 2024 •
edited
Loading

fixnuty warning:

image

@Matushl Matushl self-requested a review January 8, 2024 13:34
Matushl
Matushl approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Matushl Matushl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ešte by bolo super sa zamyslieť nad tým že či vieme z title odstrániť <--!> či čo to tam je počas loading ale to čo malo toto PR opraviť je opravené

@rtrembecky
Copy link
Collaborator Author

vyzera, ze praveze to opravilo aj to 😄 otestovane na mastri pred a po PR - pred tam bol ten tag, po uz tam nie je 🙂

@rtrembecky rtrembecky merged commit ae959ca into master Apr 12, 2024
1 check passed
@rtrembecky rtrembecky deleted the browser-title-single-text-node branch April 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matushl Matushl Matushl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtrembecky @Matushl