-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/BAR-161] Tab 컴포넌트 Switcher 디자인 구현 #42
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2c07204
chore(package): framer-motion 추가
dmswl98 7ba314b
chore(assets): 아이콘 추가
dmswl98 5936382
feat(Tab): filter, switcher 타입 추가
dmswl98 55a611e
feat(Tab): tab 타입별 스토리 코드 추가
dmswl98 232134f
fix: 옵셔널 타입으로 수정
dmswl98 b3b8679
feat: Tabs.Trigger에 아이콘을 추가하는 경우, 아닌 경우의 스토리 코드 추가
dmswl98 5ec2da7
fix: 삼항 연산자에서 && 연산자로 수정
dmswl98 43284ee
refactor: 조건부 아이콘 렌더링 조건 수정
dmswl98 f11433d
Merge branch 'main' into feature/BAR-161
dmswl98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,13 @@ | ||
import type { PropsWithChildren } from 'react'; | ||
|
||
import { useTabsContext } from '@hooks/useTabsContext'; | ||
|
||
import * as styles from '../style.css'; | ||
|
||
const TabsList = ({ children }: PropsWithChildren) => { | ||
return <ul className={styles.tabsList}>{children}</ul>; | ||
const { type } = useTabsContext(); | ||
|
||
return <ul className={styles.tabsList({ type })}>{children}</ul>; | ||
}; | ||
|
||
export default TabsList; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongkyun-dev @wonjin-dev
개인적으로 궁금한 부분인데
아이콘 상태에 따라 구분짓고 아이콘과 관련된 값을 그룹핑하기 위해 객체 prop으로 정의해두었는데 이렇게도 많이 사용하나요? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmswl98
저라면 굳이 객체로 그룹핑하지 않았을 것 같긴 합니다.