[Feature/BAR-161] Tab 컴포넌트 Switcher 디자인 구현 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miro-ring
reviewed
Jan 18, 2024
Comment on lines
+53
to
+55
| fontSize: '16px', | ||
| fontWeight: 500, | ||
| lineHeight: '19px', |
There was a problem hiding this comment.
@dmswl98
여기서는 sprinkle 사용이 어렵나요?
There was a problem hiding this comment.
ㅋㅋㅋ위에 적어두었는데...🤣
sprinkles를 이용해서 typography를 작성하는 경우,
만약 hover 상태에 typography의 특정 속성을 변경하는 코드를 작성하면 적용되지 않더라구요!
그래서 일단 임시로 sprinkles를 사용하지 않고 작성해두었어요.
There was a problem hiding this comment.
앗앗...ㅎㅎ 죄송합니다. 이전에 말씀주셨던 그 문제라 비슷한 경우인가 보군요.....ㅠㅠ 저도 주말에 반드시 한번 봐보겟습니다!
dmswl98
commented
Jan 19, 2024
Comment on lines
+119
to
+124
| <Tabs type="filter" defaultValue="끄적이는"> | ||
| <Tabs.List> | ||
| <Tabs.Trigger | ||
| value="끄적이는" | ||
| icon={{ default: 'pencilDefault', active: 'pencilActive' }} | ||
| > |
There was a problem hiding this comment.
@dongkyun-dev @wonjin-dev
개인적으로 궁금한 부분인데
아이콘 상태에 따라 구분짓고 아이콘과 관련된 값을 그룹핑하기 위해 객체 prop으로 정의해두었는데 이렇게도 많이 사용하나요? 👀
There was a problem hiding this comment.
@dmswl98
저라면 굳이 객체로 그룹핑하지 않았을 것 같긴 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Reviewers
2024-01-19.2.58.21.mov
filter라고 정의하고, 추가적으로switcher타입도 구현해두었어요.2024-01-18.2.23.33.mov
switcher) 아이콘을 허용하는게 코드적으로도 부자연스러운 것 같아 범용적으로 아이콘을 넣을 수 있도록 구현해두었어요.이슈
sprinkles를 이용해서 typography를 작성했을 때, hover 상태에 특정 font-weight을 변경하는 부분은 적용이 되지 않아 일단 임시로sprinkles를 사용하지 않고 작성해두었어요.How To Test