Color detect

[denolf]

Adding the color detect vision pipeline. This is should only be merged after #757.

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

black

reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|241|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|247|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|253|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|259|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|292|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|294|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|309|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|316|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|319|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|325|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|329|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|331|
reference_designs/ipu-xrt/vision_pipelines/color_detect/aie2_colorDetect.py|335|

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/3)

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (2/3)

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (3/3)

[github-actions]

Coverage Report

Created: 2023-12-20 12:30

Click here for information about interpreting this report.

Filename	Function Coverage	Line Coverage	Region Coverage	Branch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Dialect/AIE/IR/AIEDialect.cpp	92.11%	83.31%	85.99%	76.03%
Totals	92.11%	83.31%	85.99%	76.03%

Generated by llvm-cov -- llvm version 14.0.0

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/3)

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (2/3)

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (3/3)

[jackl-xilinx]

Added missing lut_inv_8b.h

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[makslevental]

@AndraBisca I tried to bump this but I can't get it to work; something is going wrong in the objectfifo passes; I get

  File "/home/mlevental/dev_projects/mlir-aie/cmake-build-debug/python/aie/compiler/aiecc/main.py", line 848, in run_flow
    self.run_passes(
  File "/home/mlevental/dev_projects/mlir-aie/cmake-build-debug/python/aie/compiler/aiecc/main.py", line 102, in run_passes
    PassManager.parse(pass_pipeline).run(module.operation)
aie._mlir_libs._site_initialize.<locals>.MLIRError: Failure while executing pass pipeline:
error: "-":122:9: 'func.call' op operand type mismatch: expected operand type 'memref<256xui8>', but provided 'memref<64xui8>' for operand number 1
 note: "-":122:9: see current operation: "func.call"(%9, %6, %85) <{callee = @gray2rgbaLine}> : (memref<64xui8>, memref<64xui8>, i32) -> ()

even though the input ir to aiecc is legal/fine.

[makslevental]

nm I got it - OF_5to5b was the wrong size (needs to be ofifo_line_bytes_ty). Probably AIE.objectfifo.acquire should verify that the fifo it acquires from is the right size...

[AndraBisca]

Thank you @makslevental! That check makes sense to add, I actually thought I already did but it seems not.

[makslevental]

Thank you @makslevental! That check makes sense to add, I actually thought I already did but it seems not.

FYI I added it here to double check my understanding.