use structs instead of pairs #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
make_structs
branch
from
f7517ad to
eb5b8a6
Compare
makslevental
force-pushed
the
make_structs
branch
from
eb5b8a6 to
de763db
Compare
makslevental
requested review from
stephenneuendorffer,
erwei-xilinx,
fifield,
AndraBisca,
jsetoain and
jgmelber
jsetoain
reviewed
Nov 5, 2023
There was a problem hiding this comment.
I haven't finished with the review yet (it's a big one), but this is a fantastic refactor, long overdue. I wanted to give you a heads-up while I finish the review, I see you're changing a lot of signed integers to unsigned ones. The general preference is to use signed types unless there's a good reason not to.
makslevental
force-pushed
the
make_structs
branch
3 times, most recently
from
f186a1d to
2ccf0ed
Compare
makslevental
force-pushed
the
make_structs
branch
from
2ccf0ed to
0c02722
Compare
makslevental
force-pushed
the
make_structs
branch
from
a849f5a to
a6611b7
Compare
| @@ -232,24 +259,74 @@ template <> struct DenseMapInfo<xilinx::AIE::ObjectFifoAcquireOp> { | |||
| } // namespace llvm | |||
|
|
|||
| namespace llvm { | |||
| using namespace xilinx::AIE; | |||
There was a problem hiding this comment.
Is 'using namespace' legit for headers?
| return std::tie(col, row) != std::tie(rhs.col, rhs.row); | ||
| } | ||
|
|
||
| inline bool operator<(const TileID &rhs) const { |
There was a problem hiding this comment.
This probably deserves a comment.
AndraBisca
approved these changes
Nov 6, 2023
jsetoain
approved these changes
Nov 6, 2023
|
Outstanding TODOs:
|
makslevental
force-pushed
the
make_structs
branch
from
601b14b to
07e4d24
Compare
This was referenced Nov 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use structs instead of pairs so that semantic info is preserved (and code is more readable).