Navigator: Deprecate 36px default size for buttons #68330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
mirka
force-pushed
the
button/navigator
branch
from
c8a4367 to
161b495
Compare
mirka
changed the base branch from
button-deprecate-size
to
button/dropdown-menu
mirka
commented
Dec 26, 2024
| return { | ||
| as, | ||
| as: as ?? Button, | ||
| __shouldNotWarnDeprecated36pxSize: as === undefined, |
There was a problem hiding this comment.
This is to prevent a redundant warning from Button when Navigator.BackButton has already warned.
|
Size Change: +213 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
mirka
added
the
Needs Dev Note
mirka
commented
Dec 26, 2024
| @@ -146,6 +146,7 @@ export default function PreferencesModalTabs( { sections } ) { | |||
| gap="6" | |||
| > | |||
| <Navigator.BackButton | |||
| size="compact" | |||
There was a problem hiding this comment.
In the block editor, open the Preferences modal in a narrow viewport.
| Before | After |
|---|---|
 |
 |
|
Flaky tests detected in 3069986. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12508932939
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
force-pushed
the
button/navigator
branch
from
de34c14 to
0968739
Compare
mirka
force-pushed
the
button/navigator
branch
from
0968739 to
3069986
Compare
25 tasks
tyxla
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65751
Stacked on #68329
What?
Deprecate the 36px default size on
Navigator.ButtonandNavigator.BackButton.Testing Instructions
__next40pxDefaultSizeprop enabled