Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Deprecate 36px default size #68328

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Button: Deprecate 36px default size #68328

wants to merge 3 commits into from
+45 −10

Conversation

mirka
Copy link
Member

@mirka mirka commented Dec 26, 2024 •
edited
Loading

Part of #65751

🚧 On hold while stacked and prerequisite PRs are reviewed:

What?

Deprecate the 36px default size on Button.

Testing Instructions

  • Unit tests pass
  • Storybook stories should not log console warnings
  • All code snippets in immediate documentation (JSDoc, Storybook, README) should have the __next40pxDefaultSize prop enabled. (Excluding documentation that is not specifically to document the Button component, as decided in Button: Add __next40pxDefaultSize to Markdown docs #67540.)

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Dec 26, 2024
@mirka mirka self-assigned this Dec 26, 2024
This was referenced Dec 26, 2024
Open
Open
@github-actions GitHub Actions
Copy link

Flaky tests detected in 7f84cd2.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12507018381
📝 Reported issues:

@mirka mirka mentioned this pull request Dec 26, 2024
Merged
@mirka mirka added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Dec 26, 2024
This was referenced Dec 26, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra will be requested when the pull request is marked ready for review ajitbohra is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mirka mirka

Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mirka