Widget Editor: Don't close the inserter when focusing outside it #67838
+2
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Inserter
t-hamano
requested review from
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Note: This issue first appeared in WP 6.7, so it might be worth backporting it to WP 6.7.2. |
|
Size Change: -29 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9ebf0e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12408246905
|
jeryj
reviewed
Dec 11, 2024
There was a problem hiding this comment.
I wonder if the fix should be with the appender focus on close behavior you found. Rather than always focusing the appender when the quick inserter gets closed, we only want to focus the appender when escape is pressed. I wonder if the fix in the social icon PR was too heavy handed and needs to be revisited.
packages/edit-widgets/src/components/secondary-sidebar/inserter-sidebar.js
Show resolved
Hide resolved
|
I opened #67851 to see if removing the part you found would fix it as well. It does seem to be working cleanly and handles the focus and closing. |
t-hamano
force-pushed
the
widgets/fix/inserter-open
branch
from
29a9ecf to
2ea929c
Compare
t-hamano
force-pushed
the
widgets/fix/inserter-open
branch
from
2ea929c to
9ebf0e8
Compare
t-hamano
added
[Type] Enhancement
|
If it makes the main inserter behavior more consistent between all editors, then I think it's a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #67809
In the widget editor, if you click "Browse all" after clicking the button inserter, the main inserter doesn't open. To solve this issue, we will not close the main inserter even if the focus is outside of it.
Why?
I identified this issue as being caused by #64877. The most likely cause is as follows, but note that there are two issues intertwined:
useDialoghook. Since the button inserter is focused again, it is determined that "the outside is focused" and the main inserter that is about to be opened is immediately closed. This behavior is inconsistent with other editors, which is the second problem.How?
This PR removes the
useDialoghook to only solve the second issue, meaning that the main inserter will not be closed when focus is gained outside of it, which makes it consistent with the behavior of other editors.Related PR: #61004
Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4