Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patterns from the Quick Inserter to prevent misuse in block-specific contexts #67738

Merged

Conversation

rohitmathur-7
Copy link
Contributor

@rohitmathur-7 rohitmathur-7 commented Dec 9, 2024

What?

Why?

  • We are removing Patterns from the quick inserter to prevent misuse in block-specific contexts.

How?

  • Set maxBlockPatterns to 0 which will help in not showing patterns in the quick inserter.

Testing Instructions

  • Open the block editor and add any block (e.g., Social Links).
  • Click the “+” button in the block toolbar to open the Quick Inserter.
  • Search for items, and observe that patterns are not included in the results.

Copy link

github-actions bot commented Dec 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rohitmathur-7 <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitmathur-7 Thanks for working on this. This will be a really great change to get merged.

In testing I still see at least one issue to resolve.

The + appender button tooltip still says 'Add pattern' instead of 'Add block':
Screenshot 2024-12-10 at 4 13 13 pm

I think you can probably go through the code a bit more and remove instances of prioritizePatterns and related code, as that seems to be what causes the issue.

@rohitmathur-7
Copy link
Contributor Author

@rohitmathur-7 Thanks for working on this. This will be a really great change to get merged.

In testing I still see at least one issue to resolve.

The + appender button tooltip still says 'Add pattern' instead of 'Add block': Screenshot 2024-12-10 at 4 13 13 pm

I think you can probably go through the code a bit more and remove instances of prioritizePatterns and related code, as that seems to be what causes the issue.

Sure @talldan ,
Apologies for the delayed response 🙇‍♂️, and thank you so much for reviewing the code.
I’ll work on the suggested changes today. 🚀

@rohitmathur-7
Copy link
Contributor Author

Hii @talldan ,
I have updated the code to remove prioritizePatterns instances from wherever possible.
Can you please review the code again? 🙇
Thanks!

@talldan talldan added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label Dec 17, 2024
@talldan talldan added the [Type] Bug An existing feature does not function as intended label Dec 17, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR, @rohitmathur-7 .

This testing well, I'll approve and merge the PR.

@talldan
Copy link
Contributor

talldan commented Dec 17, 2024

Fixes Issue: #67693

@rohitmathur-7 A useful feature in github is that if you write this in a particular shorthand in the PR description, like 'Fixes #67693' , then github will automatically link the PR to the issue, and when the PR is merged the issue gets closed automatically.

You can see an example on #67838, if you hover your mouse over word 'Fixes' then there's a little tooltip. It also works with some other words like 'Closes'.

@talldan talldan merged commit 581de9f into WordPress:trunk Dec 17, 2024
67 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 17, 2024
@rohitmathur-7
Copy link
Contributor Author

Hi @talldan,
Thank you so much for reviewing, testing, and merging the PR! 🙇‍♂️🚀
I also appreciate the suggestion and will keep it in mind for future PRs. 😄

yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…ecific contexts (WordPress#67738)

* Remove patterns from quick inserter

* Remove commented code

* Removed prioritizePatterns instances where possible

----

Co-authored-by: rohitmathur-7 <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: richtabor <[email protected]>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…ecific contexts (WordPress#67738)

* Remove patterns from quick inserter

* Remove commented code

* Removed prioritizePatterns instances where possible

----

Co-authored-by: rohitmathur-7 <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: richtabor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove patterns from the Quick Inserter to prevent misuse in block-specific contexts
2 participants