Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patterns from the Quick Inserter to prevent misuse in block-specific contexts #67693

Closed
richtabor opened this issue Dec 6, 2024 · 0 comments · Fixed by #67738
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

Description:

Patterns are currently available in the Quick Inserter across all contexts, including situations where they are not relevant or appropriate (e.g., the Social Links block). This creates confusion and can disrupt the intended user experience for block-specific tools.

There are two routes here: Either removing patterns from the quick inserter altogether, or remove them when they're not inserter-able anyhow (i.e. Buttons block, Social links block, etc).

I lean towards altogether, as patterns is shifting towards a more of a higher-up insertion flow via the Inserter. We could consider a user's patterns to render, but not theme patterns, if this is too much of a shift.

Steps to Reproduce:

  1. Open the block editor and add any block (e.g., Social Links).
  2. Click the “+” button in the block toolbar to open the Quick Inserter.
  3. Search for items, and observe that patterns are included in the results .

Expected:

The Quick Inserter displays block-level options relevant to the current context, excluding patterns entirely unless explicitly accessed from the Patterns tab in the main Inserter.

Suggested Fix:

Restrict the Quick Inserter to show only individual blocks and block-level items, removing patterns from its scope. Patterns should only be accessible through the Patterns tab in the main inserter for better contextual relevance and usability.

Visual

Inserting a pattern within a block-level context:

CleanShot.2024-12-06.at.09.07.09.mp4

Inserting a pattern within the social links block:

CleanShot.2024-12-06.at.09.11.53.mp4
@richtabor richtabor added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant