-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add stories for BlockCard component #67191
Storybook: Add stories for BlockCard component #67191
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @t-hamano, Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've noticed that the documentation for this component is incomplete.
- JSDoc is missing (See this comment).
- The
name
prop is missing in the README.
Could you address these? we can include them in this PR or we can submit a new PR.
packages/block-editor/src/components/block-card/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-card/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-card/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-card/stories/index.story.js
Outdated
Show resolved
Hide resolved
Hi @t-hamano, |
Hi @t-hamano, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I have one last suggestion left, but it works fine 👍
packages/block-editor/src/components/block-card/stories/index.story.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Part of: #67165
What?
This PR will add stories for the BlockCard component in the Storybook
Screencast:
Screen.Recording.2024-12-12.at.2.07.32.PM.mov