Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add stories for BlockCard component #67191

Merged

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Nov 21, 2024

Part of: #67165

What?

This PR will add stories for the BlockCard component in the Storybook

Screencast:

Screen.Recording.2024-12-12.at.2.07.32.PM.mov

Copy link

github-actions bot commented Nov 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Nov 22, 2024
@miminari miminari requested review from getdave and removed request for ellatrix November 28, 2024 23:39
@Infinite-Null
Copy link
Contributor Author

Infinite-Null commented Dec 12, 2024

Hi @t-hamano,
I’ve implemented the changes outlined in issue #67165. Please review and let me know if any further adjustments are needed.

Thank you!
cc: @adamsilverstein

@t-hamano t-hamano self-requested a review December 14, 2024 10:18
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've noticed that the documentation for this component is incomplete.

  • JSDoc is missing (See this comment).
  • The name prop is missing in the README.

Could you address these? we can include them in this PR or we can submit a new PR.

@Infinite-Null
Copy link
Contributor Author

  • this comment

Hi @t-hamano,
Since this PR primarily focuses on the Storybook, it would be better to open a separate PR specifically for the component documentation. I’ll work on completing the Storybook here and will open a follow-up PR for the documentation shortly after.

@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,
I have implemented all the suggested changes in the PR. Please review it at your convenience.
Thank you.
cc: @adamsilverstein

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I have one last suggestion left, but it works fine 👍

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 3159fa2 into WordPress:trunk Dec 18, 2024
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants