Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add JSDoc and update README for BlockCard component #68114

Merged

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Dec 19, 2024

Part of: #67165
Follow up of: #67191

What?

  • Add JSDoc documentation to the BlockCard component.
  • Update README.md to document the name prop, which was previously missing.

Copy link

github-actions bot commented Dec 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,
This is a follow-up PR for #67191 addressing the feedback in this comment. It adds JSDoc and includes the name prop in the README.md. Please have a look at it at your convenience.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

packages/block-editor/src/components/block-card/index.js Outdated Show resolved Hide resolved
@t-hamano t-hamano added Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers labels Dec 23, 2024
@Infinite-Null
Copy link
Contributor Author

Hi @t-hamano,

I’ve implemented the suggested changes and resolved the merge conflict. When you have a moment, could you please review it. Thank you!

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit ead6fac into WordPress:trunk Dec 25, 2024
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants