Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Improve overrides modal for enabling and disabling #61948

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

shreya0204
Copy link
Contributor

@shreya0204 shreya0204 commented May 24, 2024

What?

This update enhances the text descriptions in the Enable Overrides and Disable Overrides modals.

Closes #61542

Why?

The previous descriptions in the modals were concise but could lead to confusion about what exactly happens when overrides are enabled or disabled. The updated text is intended to provide a clearer, more direct explanation suitable for all users, helping them make informed decisions while managing block overrides.

How?

  • Updated the text in the Enable Overrides modal to more explicitly describe the impact of enabling an override on a block within any synced pattern instance.
  • Revised the Disable Overrides modal text to clarify the consequences of disabling an override, including how it affects the content across instances.

Testing Instructions

  1. Ensure any full site editing (FSE) theme is active.
  2. Navigate to the site editor.
  3. Add a synced block pattern.
  4. Insert a heading block.
  5. Open the right-side inspector controls.
  6. Expand the Advanced section.
  7. Click on the "Enable Overrides" button; the modal will display the updated message.
  8. Enter a name for the block and click Enable.
  9. After enabling, select the heading block again and click on Disable Overrides, the modal with the updated message about disabling will appear.

Testing Instructions for Keyboard

Screenshots or screencast

Enable

enable

Disable

disable

Copy link

github-actions bot commented May 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shreya0204 <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: provenself <[email protected]>
Co-authored-by: marybaum <[email protected]>
Co-authored-by: annezazu <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 24, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shreya0204! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@talldan talldan added [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Copy Issues or PRs that need copy editing assistance labels Jun 5, 2024
@talldan talldan added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 5, 2024
@richtabor
Copy link
Member

I'm missing the explanation of what an override is, from the previous iteration. And so few people will read that long paragraph of content when disabling.

@ellatrix
Copy link
Member

@talldan Is this something that is needed for 6.6?

@talldan talldan removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 21, 2024
@talldan
Copy link
Contributor

talldan commented Jun 21, 2024

Is this something that is needed for 6.6?

@ellatrix I've removed the label. Given the string freeze is soon, it seems fine to bump it until there's more clarity on the right copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy: improve overrides modal for enabling and disabling
4 participants