-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Improve overrides modal for enabling and disabling #61948
base: trunk
Are you sure you want to change the base?
Update: Improve overrides modal for enabling and disabling #61948
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shreya0204! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I'm missing the explanation of what an override is, from the previous iteration. And so few people will read that long paragraph of content when disabling. |
@talldan Is this something that is needed for 6.6? |
@ellatrix I've removed the label. Given the string freeze is soon, it seems fine to bump it until there's more clarity on the right copy. |
What?
This update enhances the text descriptions in the
Enable Overrides
andDisable Overrides
modals.Closes #61542
Why?
The previous descriptions in the modals were concise but could lead to confusion about what exactly happens when overrides are enabled or disabled. The updated text is intended to provide a clearer, more direct explanation suitable for all users, helping them make informed decisions while managing block overrides.
How?
Enable Overrides
modal to more explicitly describe the impact of enabling an override on a block within any synced pattern instance.Disable Overrides
modal text to clarify the consequences of disabling an override, including how it affects the content across instances.Testing Instructions
Advanced
section.Enable
.Disable Overrides
, the modal with the updated message about disabling will appear.Testing Instructions for Keyboard
Screenshots or screencast
Enable
Disable