Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy: improve overrides modal for enabling and disabling #61542

Open
annezazu opened this issue May 9, 2024 · 7 comments · May be fixed by #61948
Open

Copy: improve overrides modal for enabling and disabling #61542

annezazu opened this issue May 9, 2024 · 7 comments · May be fixed by #61948
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented May 9, 2024

For enabling and disabling overrides, I found the copy to be a bit stiff and hard to understand. Let's try to iterate (if we can).

Enabling:

Overrides are changes you make to a block within a synced pattern instance. Use overrides to customize a synced pattern instance to suit its new context. Name this block to specify an override.

Screenshot 2024-05-09 at 3 10 22 PM

Disabling:

Are you sure you want to disable overrides? Disabling overrides will revert all applied overrides for this block throughout instances of this pattern.

Screenshot 2024-05-09 at 3 10 29 PM

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels May 9, 2024
@annezazu
Copy link
Contributor Author

Some riffing:

Overrides are changes you make to a block within a synced pattern instance. Use overrides to customize a synced pattern instance to suit its new context. Name this block to specify an override.

Adding an override will allow this block to be edited within any instance of this synced pattern. To set an override, name this block.

Are you sure you want to disable overrides? Disabling overrides will revert all applied overrides for this block throughout instances of this pattern.

Are you sure you want to disable an override for this block? By disabling, any customized content for this block throughout every instance of this pattern will be reverted to the original synced pattern.

@provenself
Copy link

These are looking good! Defer to you on the actual functionality, but these feel a little different:

within a synced pattern instance

and

within any instance of this synced pattern

That is, I read the original as overriding turning a chosen instance into its own new pattern; I read the revision as overriding across the pattern ("any" functioning as "every"). (Secondarily, I'm not clear how this differs from "detach" in the current version.) To that tend, suggesting a tiny tweak:

Adding an override will allow this block to be edited within any instance of this synced pattern. To set an override, name this block.

Adding an override will make this block editable within a chosen instance of the synced pattern. To set an override, name this block.

Are you sure you want to disable an override for this block? By disabling, any customized content for this block throughout every instance of this pattern will be reverted to the original synced pattern.

Are you sure you want to disable an override for this block? Any customized content for this block throughout every instance of this pattern will be reverted to the original synced pattern.

@marybaum
Copy link
Member

I think I would make this singular (and how much experience does the person who sees this have with synced patterns?) If a relatively new person, maybe something like this:

An override is a change you make to a block inside a particular instance of a synced pattern. Generally, you'll do that to make the pattern more specific to what you're doing. Name the block with the override, and you'll have saved it to edit later in any instance of that synced pattern.

The second sentence is optional, I think, but tells a new user why they might want to do the override.

To disable:

Are you sure you want to disable this override? If you do, any custom content in this block, across every instance of this pattern, will disappear, and the content of the original synced pattern will replace it.

More jarring, but clearer in the implications.

@annezazu
Copy link
Contributor Author

Thank you both for helping here! Merging suggestions from you both and landing here to keep it concise yet clear:

Enabling an override

Adding an override will allow this block to be edited within any instance of this synced pattern. To set an override, name this block.

Disabling an override

Are you sure you want to disable an override for this block? By disabling, any custom content for this block throughout every instance of this pattern will be reverted to the original content of the synced pattern.

Going to have this as a needs dev task :)

@annezazu annezazu added Needs Dev Ready for, and needs developer efforts and removed Needs Copy Review Needs review of user-facing copy (language, phrasing) labels May 22, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 24, 2024
@shreya0204
Copy link
Contributor

Hi @annezazu

I've made some changes to the modal message in Gutenberg to better explain the override settings. Could you please review them at your convenience?

@talldan talldan added the Needs Design Feedback Needs general design feedback. label Jun 5, 2024
@talldan
Copy link
Contributor

talldan commented Jun 5, 2024

The changes look good to me. I think @richtabor worked on the copy originally, so might be good to loop in on the changes.

@talldan
Copy link
Contributor

talldan commented Jun 21, 2024

Removing this from the 6.6 board given the string freeze is coming up and there's still discussion on the PR about the right copy - #61948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants