-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy: improve overrides modal for enabling and disabling #61542
Comments
Some riffing:
Adding an override will allow this block to be edited within any instance of this synced pattern. To set an override, name this block.
Are you sure you want to disable an override for this block? By disabling, any customized content for this block throughout every instance of this pattern will be reverted to the original synced pattern. |
These are looking good! Defer to you on the actual functionality, but these feel a little different:
and
That is, I read the original as overriding turning a chosen instance into its own new pattern; I read the revision as overriding across the pattern ("any" functioning as "every"). (Secondarily, I'm not clear how this differs from "detach" in the current version.) To that tend, suggesting a tiny tweak:
Adding an override will make this block editable within a chosen instance of the synced pattern. To set an override, name this block.
Are you sure you want to disable an override for this block? Any customized content for this block throughout every instance of this pattern will be reverted to the original synced pattern. |
I think I would make this singular (and how much experience does the person who sees this have with synced patterns?) If a relatively new person, maybe something like this:
The second sentence is optional, I think, but tells a new user why they might want to do the override. To disable:
More jarring, but clearer in the implications. |
Thank you both for helping here! Merging suggestions from you both and landing here to keep it concise yet clear: Enabling an override
Disabling an override
Going to have this as a needs dev task :) |
Hi @annezazu I've made some changes to the modal message in Gutenberg to better explain the override settings. Could you please review them at your convenience? |
The changes look good to me. I think @richtabor worked on the copy originally, so might be good to loop in on the changes. |
Removing this from the 6.6 board given the string freeze is coming up and there's still discussion on the PR about the right copy - #61948. |
For enabling and disabling overrides, I found the copy to be a bit stiff and hard to understand. Let's try to iterate (if we can).
Enabling:
Disabling:
The text was updated successfully, but these errors were encountered: