Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNMobile: Add new Video block capability #59144

Merged
merged 1 commit into from
Feb 23, 2024
Merged

RNMobile: Add new Video block capability #59144

merged 1 commit into from
Feb 23, 2024

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Feb 17, 2024 •
edited
Loading

What?

This PR is adding a new capability to enable changes to the Video block.

Why?

There are times where the Video block doesn't work as expected, this PR helps lay the groundwork for addressing this.

How?

Previously-used patterns to add a new capability have been followed.

Testing Instructions

See the related Gutenberg Mobile PR here for an example of when this new capability will be useful: wordpress-mobile/gutenberg-mobile#6634

This was referenced Feb 17, 2024
Merged
Merged
@SiobhyB SiobhyB changed the title RNMobile: Enable new feature RNMobile: Add new Video block capability Feb 19, 2024
@SiobhyB SiobhyB added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 19, 2024
@SiobhyB SiobhyB marked this pull request as ready for review February 19, 2024 10:30
@SiobhyB SiobhyB added the [Type] Enhancement A suggestion for improvement. label Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SiobhyB <[email protected]>
Co-authored-by: derekblank <[email protected]>
Co-authored-by: fluiddot <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This was referenced Feb 19, 2024
Merged
Merged
derekblank
derekblank approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Approving, if it's advantageous to merge the enableVideoPressV5Support flag ahead of the ongoing changes in Automattic/jetpack#35637. 🚀

@fluiddot
Copy link
Contributor

LGTM -- Approving, if it's advantageous to merge the enableVideoPressV5Support flag ahead of the ongoing changes in Automattic/jetpack#35637. 🚀

I'm hesitant to proceed with merging these changes before WP-Android and WP-iOS PRs are ready to be merged. Otherwise, we'll likely get build failures when using trunk branches across repositories.

fluiddot
fluiddot approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@SiobhyB SiobhyB merged commit 44d4886 into trunk Feb 23, 2024
66 of 67 checks passed
@SiobhyB SiobhyB deleted the rnmobile/enable-new-capability branch February 23, 2024 17:09
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

@derekblank derekblank derekblank approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 17.9
Development

Successfully merging this pull request may close these issues.
3 participants
@SiobhyB @fluiddot @derekblank