Tidying CircularOptionPicker.Option
#54903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhayward
added
[Type] Code Quality
|
Size Change: +451 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7fc9c02. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6337308503
|
andrewhayward
deleted the
enhancement/tidying_circularoptionpicker_option
branch
|
@andrewhayward This change brought the following side effect on tab-panel component. Before: After: Steps:
|
|
@madhusudhand Thanks for flagging that. Sorry it was missed. Will fix. |
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes some now-defunct styling workarounds from
CircularOptionPicker.Option, and normalises style application between it andButton.Why?
Before
Buttonwas refactored in #54740, it was necessary to explicitly add anis-pressedclass to theCircularOptionPicker.Option, to avoid usingisPressedwhich automatically addedaria-pressed. With those changes, and the refactor here,is-pressedis no longer necessary as a class forCircularOptionPicker.Option, so the workaround isn't necessary.How?
The dependency on the
is-pressedclass is removed fromCircularOptionPicker.Optioninstead using thearia-selected/aria-pressedattribute directly.aria-selectedis also added toButtonto ensure styling is normalised for other consumers.Testing Instructions
There should be no visual changes, either in
ButtonorCircularOptionPicker. Both of these components can be checked in StoryBook.Testing Instructions for Keyboard
There should be no interaction changes to either
ButtonorCircularOptionPicker.