-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting addition of aria-selected
style hook in Button
#54931
Reverting addition of aria-selected
style hook in Button
#54931
Conversation
Size Change: -25 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a quick fix 🚀 On the long term, I wonder if a better fix would be to override styles specifically in the TabPanel
component, instead of removing them from Button
Let's add a CHANGELOG entry and merge
Agreed that longer term more default consistency between |
What?
This PR removes the addition of
aria-selected
as a styling hook fromButton
.Why?
As pointed out by @madhusudhand, #54903 inadvertently changed how tabs are rendered.
How?
The
[aria-selected="true"]
selector has been removed fromButton
.Testing Instructions
Aa
or any font to invoke the font library modal.Screenshots
Before
After