Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar: add padding support #43519

Merged
merged 18 commits into from
Sep 6, 2022
Merged

Avatar: add padding support #43519

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ad6e045
Update DateTimePicker readme
colorful-tones Oct 5, 2021
4ac86ad
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 12, 2021
a8ea897
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 14, 2021
ade1023
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 15, 2021
9cc6b02
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 25, 2021
bb60f63
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 27, 2021
fb4add5
Merge branch 'WordPress:trunk' into trunk
colorful-tones Oct 28, 2021
8770819
Merge branch 'WordPress:trunk' into trunk
colorful-tones May 27, 2022
508de20
Merge branch 'WordPress:trunk' into trunk
colorful-tones Jun 27, 2022
015cc6d
Merge branch 'WordPress:trunk' into trunk
colorful-tones Aug 23, 2022
10e03af
Add padding support for Avatar block
colorful-tones Aug 23, 2022
23c0997
add box-sizing for frontend
colorful-tones Aug 23, 2022
2450375
Merge branch 'WordPress:trunk' into trunk
colorful-tones Aug 26, 2022
0e301d8
Merge branch 'trunk' into add/avatar-padding-support
colorful-tones Aug 26, 2022
bf6286d
Additional comment clarification for box-sizing
colorful-tones Aug 26, 2022
8e2a53f
Merge branch 'WordPress:trunk' into trunk
colorful-tones Aug 31, 2022
d440f0e
Merge branch 'WordPress:trunk' into trunk
colorful-tones Sep 1, 2022
765c757
Merge branch 'trunk' into add/avatar-padding-support
colorful-tones Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Add a user's avatar. ([Source](https://github.com/WordPress/gutenberg/tree/trunk

- **Name:** core/avatar
- **Category:** theme
- **Supports:** align, color (~~background~~, ~~text~~), spacing (margin), ~~alignWide~~, ~~html~~
- **Supports:** align, color (~~background~~, ~~text~~), spacing (margin, padding), ~~alignWide~~, ~~html~~
- **Attributes:** isLink, linkTarget, size, userId

## Reusable block
Expand Down Expand Up @@ -60,7 +60,7 @@ Prompt visitors to take action with a group of button-style links. ([Source](htt
- **Name:** core/buttons
- **Category:** design
- **Supports:** align (full, wide), anchor, spacing (blockGap, margin)
- **Attributes:**
- **Attributes:**

## Calendar

Expand Down Expand Up @@ -168,7 +168,7 @@ Contains the block elements used to display a comment, like the title, date, aut
- **Name:** core/comment-template
- **Category:** design
- **Supports:** align, typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
- **Attributes:**
- **Attributes:**

## Comments

Expand Down Expand Up @@ -204,7 +204,7 @@ Displays a list of page numbers for comments pagination. ([Source](https://githu
- **Name:** core/comments-pagination-numbers
- **Category:** theme
- **Supports:** typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
- **Attributes:**
- **Attributes:**

## Previous Page

Expand Down Expand Up @@ -420,7 +420,7 @@ Separate your content into a multi-page experience. ([Source](https://github.com
- **Name:** core/nextpage
- **Category:** design
- **Supports:** ~~className~~, ~~customClassName~~, ~~html~~
- **Attributes:**
- **Attributes:**

## Page List

Expand Down Expand Up @@ -519,7 +519,7 @@ Displays the contents of a post or page. ([Source](https://github.com/WordPress/
- **Name:** core/post-content
- **Category:** theme
- **Supports:** align (full, wide), ~~html~~
- **Attributes:**
- **Attributes:**

## Post Date

Expand Down Expand Up @@ -564,7 +564,7 @@ Contains the block elements used to render a post, like the title, date, feature
- **Name:** core/post-template
- **Category:** theme
- **Supports:** align, typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
- **Attributes:**
- **Attributes:**

## Post Terms

Expand Down Expand Up @@ -618,7 +618,7 @@ Contains the block elements used to render content when no query results are fou
- **Name:** core/query-no-results
- **Category:** theme
- **Supports:** align, color (background, gradients, link, text), ~~html~~, ~~reusable~~
- **Attributes:**
- **Attributes:**

## Pagination

Expand All @@ -645,7 +645,7 @@ Displays a list of page numbers for pagination ([Source](https://github.com/Word
- **Name:** core/query-pagination-numbers
- **Category:** theme
- **Supports:** color (background, gradients, ~~text~~), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
- **Attributes:**
- **Attributes:**

## Previous Page

Expand Down
3 changes: 2 additions & 1 deletion packages/block-library/src/avatar/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"align": true,
"alignWide": false,
"spacing": {
"margin": true
"margin": true,
"padding": true
},
"__experimentalBorder": {
"__experimentalSkipSerialization": true,
Expand Down
2 changes: 2 additions & 0 deletions packages/block-library/src/avatar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.wp-block-avatar {
box-sizing: border-box;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small nit, but can you add the comment

// This block has customizable padding, border-box makes that more predictable.

This keeps the implementation consistent with other blocks and makes it easy to understand why this has been added. Otherwise, this PR looks good to go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, nothing too small, and thanks for the nitpicking! I addressed the missing comment. 👍


&.aligncenter {
text-align: center;
}
Expand Down