-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar: add padding support #43519
Avatar: add padding support #43519
Conversation
@colorful-tones I believe you will want to add |
@ndiego good call! I added |
@@ -1,4 +1,6 @@ | |||
.wp-block-avatar { | |||
box-sizing: border-box; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a small nit, but can you add the comment
// This block has customizable padding, border-box makes that more predictable.
This keeps the implementation consistent with other blocks and makes it easy to understand why this has been added. Otherwise, this PR looks good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, nothing too small, and thanks for the nitpicking! I addressed the missing comment. 👍
As with the site logo block, I don't think the top and bottom margins are working? |
@carolinan From all of my tests Here is today's test avatar-padding-margin-support.mp4Here is my testing environment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this one @colorful-tones, it's working nicely for me, and the padding sits nicely next to an adjacent Group block:
The margin issue appears to be the same one as discussed in #43520 (review) (and written up in #43404) so not a blocker for merging this one in, I don't think. Update: merged and updated the tracking issue.
LGTM! ✨
Related:
What?
Add padding support to the Avatar block.
Why?
To create consistency across blocks.
How?
Added the relevant block support in
block.json
Testing Instructions
Also, test in Global Styles as well.