-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
46 jobs page #61
Merged
Merged
46 jobs page #61
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1309581
Jobs Page (60%)
YellouMeli 70d5390
Job Board (100%)
YellouMeli bdc5f4b
Fix function: Opens the URL in a new browser tab
YellouMeli 05fbb4d
add publication date to JobData
YellouMeli d4a2221
Merge branch 'main' into 46-jobs-page
YellouMeli 537241f
Corrections from PR Review (50%)
YellouMeli 8aacd26
Corrections from PR Review (100%)
YellouMeli 9a85675
Code Clean: Job Board Date Grid
YellouMeli 92981bc
code clean: add comments, colors corrections
YellouMeli 286908f
color corrections
YellouMeli 0759b02
Colors test corrections
YellouMeli a185c11
Add Job Position
YellouMeli 410783a
Job Card responsive fix
YellouMeli a944fed
job card corrections
MariaAmariya 7c773f5
Update components: /JobCard/JobCard.tsx
MariaAmariya b8aa681
Update src/theme/theme.ts
MariaAmariya 58aef4c
Merge branch 'main' into 46-jobs-page
MariaAmariya 1d59e47
Fix: lint correction
MariaAmariya 7471faa
Fix: code cleaning
MariaAmariya 3fbe3d3
Fix: code cleaning JobBoard.tsx
MariaAmariya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
import { FC } from 'react' | ||
import { Grid, Avatar, Typography, Button, Chip, Card, CardContent } from '@mui/material' | ||
import BusinessIcon from '@mui/icons-material/Business' | ||
import LocationOnIcon from '@mui/icons-material/LocationOn' | ||
import AccountBalanceWalletIcon from '@mui/icons-material/AccountBalanceWallet' | ||
import AccessTimeIcon from '@mui/icons-material/AccessTime' | ||
import JobData from '@/types/JobListing' | ||
|
||
|
||
interface JobCardProps { | ||
job: JobData | ||
} | ||
|
||
const JobCard: FC<JobCardProps> = ({ job }) => { | ||
const handleReadMoreClick = () => { | ||
window.open(job.jobPostingUrl, '_blank', 'noopener,noreferrer') | ||
} | ||
|
||
return <Card sx={{ bgcolor: 'primary.dark', width: '100%' }}> | ||
<CardContent> | ||
<Grid container spacing={1} alignItems="center"> | ||
<Grid item xs={12} sm={12} md={2} display="flex" justifyContent="center"> | ||
<Avatar | ||
sx={{ bgcolor: 'white', width: 100, height: 100, borderRadius: 2, img: {objectFit: 'contain', width: '90%', height: '100%'} | ||
}} | ||
alt={`${job.company} logo`} | ||
MariaAmariya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
src={job.logoUrl} | ||
/> | ||
</Grid> | ||
<Grid item xs={12} sm={12} md={8} mt={2}> | ||
<Typography variant="h5" mb={2} component="div" sx={{ textAlign: 'left' }}> | ||
{job.title} | ||
</Typography> | ||
<Grid container spacing={2}> | ||
<Grid item xs={12} sm={4} sx={{ display: 'flex', justifyContent: { xs: 'flex-start', sm: 'center' }, alignItems: 'center' }}> | ||
<BusinessIcon /> | ||
<Typography fontSize="body2" sx={{ ml: 1 }}>{job.company}</Typography> | ||
</Grid> | ||
<Grid item xs={12} sm={4} sx={{ display: 'flex', justifyContent: { xs: 'flex-start', sm: 'center' }, alignItems: 'center' }}> | ||
<LocationOnIcon /> | ||
<Typography fontSize="body2" sx={{ ml: 1 }}>{job.location}</Typography> | ||
</Grid> | ||
<Grid item xs={12} sm={4} sx={{ display: 'flex', justifyContent: { xs: 'flex-start', sm: 'center' }, alignItems: 'center' }}> | ||
<AccountBalanceWalletIcon /> | ||
<Typography fontSize="body2" sx={{ ml: 1 }}>{job.salary}</Typography> | ||
</Grid> | ||
</Grid> | ||
<Grid direction='row' spacing={1} mt={2} justifyContent="flex-start" flexWrap="wrap"> | ||
{job.tags.map((tag, index) => ( | ||
<Chip key={index} label={tag} sx={{ bgcolor: 'secondary.dark', height: 32, borderRadius: '8px', mt: { xs: 2, sm: 0 }, ml: { xs: 1, sm: 1 }, flexShrink: 0 }} /> | ||
))} | ||
</Grid> | ||
MariaAmariya marked this conversation as resolved.
Show resolved
Hide resolved
|
||
</Grid> | ||
<Grid item xs={12} sm={12} md={2} paddingRight={2} sx={{ order: { xs: -1, sm: -1, md: 0 }, alignSelf: { sm: 'flex-start' } }} display="flex" alignItems="center" justifyContent="right"> | ||
<AccessTimeIcon sx={{ marginRight: 2 }} /> | ||
<Typography fontSize="body2"> | ||
{ job.publicationDate } | ||
</Typography> | ||
</Grid> | ||
<Grid container spacing={1} justifyContent="right"> | ||
<Grid item> | ||
<Button | ||
variant="contained" | ||
color='tertiary' | ||
onClick={handleReadMoreClick} | ||
sx={{ | ||
mt: 1, | ||
padding: '4px 8px', | ||
}} | ||
> | ||
Read More | ||
</Button> | ||
</Grid> | ||
</Grid> | ||
</Grid> | ||
</CardContent> | ||
</Card> | ||
} | ||
|
||
export default JobCard |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import { FC, ReactNode } from 'react' | ||
import JobCard from '@/components/JobCard/JobCard' | ||
import { Container, Stack, Typography } from '@mui/material' | ||
import { useTranslation } from 'react-i18next' | ||
import job from '@/routes/JobBoard/jobs.json' | ||
import JobData from '@/types/JobListing' | ||
|
||
const JobBoard:FC = () => { | ||
const { t } = useTranslation() | ||
|
||
const jobGrid: ReactNode[] = [] | ||
job.forEach((jobDescription: JobData) => { | ||
jobGrid.push(<JobCard job={jobDescription}/>) | ||
}) | ||
|
||
return <Container style={{ padding: 32 }} aria-label="job-board-container"> | ||
<Stack spacing={4}> | ||
<Typography variant="h1">{t('job.title')}</Typography> | ||
{jobGrid} | ||
</Stack> | ||
</Container> | ||
} | ||
|
||
export default JobBoard |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,32 @@ | ||||||
[ | ||||||
{ | ||||||
"title": "Sr. Software Development Engineer, Japan Pricing and Promotions", | ||||||
"company": "Amazon Web Services", | ||||||
MariaAmariya marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"logoUrl": "/Amazon-logo.png", | ||||||
"location": "Tokyo, Japan", | ||||||
"jobPostingUrl": "https://www.amazon.jobs/en/jobs/2719073/sr-software-development-engineer-japan-pricing-and-promotions", | ||||||
"salary": "-", | ||||||
"publicationDate": "2024/08/25", | ||||||
"tags": ["Full Time", "Senior Level", "English"] | ||||||
}, | ||||||
{ | ||||||
"title": "Software Development Engineer, Amazon Points, JP Points CX", | ||||||
"company": "Amazon Web Services", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"logoUrl": "/Amazon-logo.png", | ||||||
"location": "Tokyo, Japan", | ||||||
"jobPostingUrl": "https://www.amazon.jobs/en/jobs/2725444/software-development-engineer-amazon-points-jp-points-cx", | ||||||
"salary": "-", | ||||||
"publicationDate": "2024/08/25", | ||||||
"tags": ["Full Time", "English"] | ||||||
}, | ||||||
{ | ||||||
"title": "Senior Business Intelligence Engineer, JP Retail Science", | ||||||
"company": "Amazon Web Services", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"logoUrl": "/Amazon-logo.png", | ||||||
"location": "Tokyo, Japan", | ||||||
"jobPostingUrl": "https://www.amazon.jobs/en/jobs/2560382/senior-business-intelligence-engineer-jp-retail-science", | ||||||
"salary": "-", | ||||||
"publicationDate": "2024/08/25", | ||||||
"tags": ["Full Time", "Senior Level", "SQL skills", "English"] | ||||||
} | ||||||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
type JobListing = { | ||
title: string, | ||
company: string, | ||
logoUrl: string, | ||
location: string, | ||
jobPostingUrl: string, | ||
salary: string, | ||
publicationDate: string, // date format should be YYYY/MM/DD | ||
tags: string [] | ||
} | ||
|
||
export default JobListing |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we try to compress this image, I know we can half this 🙇♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but I think the image could actually appear larger as the card has a lot of negative space. Mind if we address this in a follow up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries, that's fine too 👍