46 jobs page #61

MariaAmariya · 2024-07-27T08:15:11Z

Resolves #46

What changed 🧐

Please list the changes that are in this PR

utils/jobData
tcomponents/JobCard
routes/JobBoard

See CONTRIBUTING for guidelines

How did you test it? 🧪

*Creating the tests is pending

Fix for responsive UI

ann-kilzer

This is a great start. Thank you for working on this 😸

src/utils/jobData.ts

src/routes/Router.tsx

src/routes/JobBoard/JobBoard.tsx

src/components/JobCard/JobCard.tsx

src/utils/jobData.ts

src/components/JobCard/JobCard.tsx

ann-kilzer

Looking really nice. Left a few comments, but we're nearly there

Let's add some tests tonight.

src/components/JobCard/JobCard.tsx

src/types/JobListing.ts

src/components/JobCard/JobCard.tsx

ann-kilzer

Looks like one test failed now that we updated the tertiary value. Could you update the test before merging?

Otherwise great work! 🎊

src/routes/JobBoard/jobs.json

ann-kilzer

Oh I remembered one more thing before we ship to production.... sorry for the back-and-forth

ann-kilzer · 2024-08-22T00:19:23Z

Now that we know the jobs, let's update this accordingly 😃

sirbully · 2024-08-26T02:55:42Z

public/Amazon-logo.png

nit: can we try to compress this image, I know we can half this 🙇‍♀️

Sure, but I think the image could actually appear larger as the card has a lot of negative space. Mind if we address this in a follow up PR?

no worries, that's fine too 👍

sirbully

small request from me 🙇‍♀️

sirbully

my nit can be addressed in another pr 👍

ann-kilzer

These are all listings for Amazon Japan rather than AWS.

ann-kilzer · 2024-08-27T12:57:48Z

src/routes/JobBoard/jobs.json

+    },
+    {
+        "title": "Software Development Engineer, Amazon Points, JP Points CX",
+        "company": "Amazon Web Services",


Suggested change

"company": "Amazon Web Services",

"company": "Amazon Japan",

ann-kilzer · 2024-08-27T12:58:03Z

src/routes/JobBoard/jobs.json

+    },
+    {
+        "title": "Senior Business Intelligence Engineer, JP Retail Science",
+        "company": "Amazon Web Services",


Suggested change

"company": "Amazon Web Services",

"company": "Amazon Japan",

ann-kilzer · 2024-08-27T13:05:20Z

src/routes/JobBoard/jobs.json

+[
+    {
+        "title": "Sr. Software Development Engineer, Japan Pricing and Promotions",
+        "company": "Amazon Web Services",


Suggested change

"company": "Amazon Web Services",

"company": "Amazon Japan",

ann-kilzer

I think this is nearly ready to ship, once we fix the company name. Thanks for your hard work!

In iteration 2 (separate PR) let's improve the gridding to aid readability:

Logo should be larger and top border should be aligned with the job title. The actual image size should match the CSS sizing so that the data loads quickly.
The date element should also fall along this same line
The tags should have no margin on the left hand side so it aligns with title and company
Let's hide the salary element if no information is provided
Let's move the READ MORE button to align with the bottom of the tags

Here's an example I made in GIMP of the gridding:

Fixed: Company Name, JobCard Design

ann-kilzer

Nice work! A few small adjustments to the gridding but overall this looks good. Feel free to merge once you've made the fixes and resolved the merge conflict.

src/components/JobCard/JobCard.tsx

src/theme/theme.ts

Co-authored-by: Ann Kilzer キルザー杏 <[email protected]>

# Conflicts: # src/theme/theme.ts

YellouMeli added 4 commits July 14, 2024 21:09

Jobs Page (60%)

1309581

Job Board (100%)

70d5390

Fix for responsive UI

Fix function: Opens the URL in a new browser tab

bdc5f4b

add publication date to JobData

05fbb4d

MariaAmariya requested review from ann-kilzer and sirbully as code owners July 27, 2024 08:15

MariaAmariya self-assigned this Jul 27, 2024

ann-kilzer reviewed Jul 27, 2024

View reviewed changes

YellouMeli added 4 commits August 3, 2024 17:23

Merge branch 'main' into 46-jobs-page

d4a2221

Corrections from PR Review (50%)

537241f

Corrections from PR Review (100%)

8aacd26

Code Clean: Job Board Date Grid

9a85675

ann-kilzer reviewed Aug 4, 2024

View reviewed changes

src/components/JobCard/JobCard.tsx Outdated Show resolved Hide resolved

src/types/JobListing.ts Outdated Show resolved Hide resolved

src/types/JobListing.ts Outdated Show resolved Hide resolved

src/components/JobCard/JobCard.tsx Outdated Show resolved Hide resolved

YellouMeli added 2 commits August 4, 2024 19:41

code clean: add comments, colors corrections

92981bc

color corrections

286908f

ann-kilzer approved these changes Aug 4, 2024

View reviewed changes

Colors test corrections

0759b02

ann-kilzer reviewed Aug 5, 2024

View reviewed changes

src/routes/JobBoard/jobs.json Outdated Show resolved Hide resolved

ann-kilzer requested changes Aug 5, 2024

View reviewed changes

YellouMeli added 2 commits August 25, 2024 13:58

Add Job Position

a185c11

Job Card responsive fix

410783a

MariaAmariya requested a review from ann-kilzer August 25, 2024 11:01

sirbully reviewed Aug 26, 2024

View reviewed changes

sirbully requested changes Aug 26, 2024

View reviewed changes

sirbully approved these changes Aug 26, 2024

View reviewed changes

ann-kilzer reviewed Aug 27, 2024

View reviewed changes

job card corrections

a944fed

Fixed: Company Name, JobCard Design

ann-kilzer approved these changes Sep 1, 2024

View reviewed changes

src/components/JobCard/JobCard.tsx Show resolved Hide resolved

src/components/JobCard/JobCard.tsx Outdated Show resolved Hide resolved

src/components/JobCard/JobCard.tsx Outdated Show resolved Hide resolved

src/theme/theme.ts Outdated Show resolved Hide resolved

MariaAmariya and others added 6 commits September 1, 2024 20:20

Update components: /JobCard/JobCard.tsx

7c773f5

Update src/theme/theme.ts

b8aa681

Co-authored-by: Ann Kilzer キルザー杏 <[email protected]>

Merge branch 'main' into 46-jobs-page

58aef4c

# Conflicts: # src/theme/theme.ts

Fix: lint correction

1d59e47

Fix: code cleaning

7471faa

Fix: code cleaning JobBoard.tsx

3fbe3d3

MariaAmariya merged commit c23c402 into main Sep 1, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

46 jobs page #61

46 jobs page #61

MariaAmariya commented Jul 27, 2024 •

edited

Loading

ann-kilzer left a comment

ann-kilzer left a comment

ann-kilzer left a comment

ann-kilzer left a comment

ann-kilzer commented Aug 22, 2024

sirbully Aug 26, 2024

ann-kilzer Aug 26, 2024

sirbully Aug 26, 2024

sirbully left a comment

sirbully left a comment

ann-kilzer left a comment

ann-kilzer Aug 27, 2024

ann-kilzer Aug 27, 2024

ann-kilzer Aug 27, 2024

ann-kilzer left a comment

ann-kilzer left a comment

46 jobs page #61

46 jobs page #61

Conversation

MariaAmariya commented Jul 27, 2024 • edited Loading

What changed 🧐

How did you test it? 🧪

ann-kilzer left a comment

Choose a reason for hiding this comment

ann-kilzer left a comment

Choose a reason for hiding this comment

ann-kilzer left a comment

Choose a reason for hiding this comment

ann-kilzer left a comment

Choose a reason for hiding this comment

ann-kilzer commented Aug 22, 2024

sirbully Aug 26, 2024

Choose a reason for hiding this comment

ann-kilzer Aug 26, 2024

Choose a reason for hiding this comment

sirbully Aug 26, 2024

Choose a reason for hiding this comment

sirbully left a comment

Choose a reason for hiding this comment

sirbully left a comment

Choose a reason for hiding this comment

ann-kilzer left a comment

Choose a reason for hiding this comment

ann-kilzer Aug 27, 2024

Choose a reason for hiding this comment

ann-kilzer Aug 27, 2024

Choose a reason for hiding this comment

ann-kilzer Aug 27, 2024

Choose a reason for hiding this comment

ann-kilzer left a comment

Choose a reason for hiding this comment

ann-kilzer left a comment

Choose a reason for hiding this comment

MariaAmariya commented Jul 27, 2024 •

edited

Loading