This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
CVE page #617
Merged
CVE page #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select max vulnerability urgency and pub_date in CVEView.
a-martynovich
force-pushed
the
543-cve-page
branch
from
f892f4f to
a4a6f8d
Compare
Merged
|
Popovers are now implemented. They are toggled on click.
|
rptrchv
suggested changes
Jan 15, 2020
Add comments to Device.cve_count. Add unique constraint to Vulnerability. Add default case for migration convert_urgencies(). PEP8 fixes.
|
all fixed |
rptrchv
suggested changes
Jan 16, 2020
| @@ -5,6 +5,7 @@ | |||
| from itertools import chain | |||
| import time | |||
|
|
|||
| import dateutil.parser | |||
There was a problem hiding this comment.
Pls put it to appropriate group of imports
| @@ -806,6 +826,9 @@ class Meta: | |||
|
|
|||
|
|
|||
| class Vulnerability(models.Model): | |||
| class Meta: | |||
| unique_together = ['os_release_codename', 'name', 'package'] | |||
There was a problem hiding this comment.
Probably that's not ok because you need to have unique names for each os and having 'package' here will break this constraint logic.
There was a problem hiding this comment.
No, for each OS there may be multiple vulnerabilities with the same name but different packages. It's when one CVE affects multiple packages.
rptrchv
approved these changes
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543
New URLs:
/cve,/devices/<pk>/cveMay need additional optimisation.