This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
CVE page: optimise, fix popovers #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-martynovich
force-pushed
the
543-cve-page
branch
4 times, most recently
from
1e97a7c to
108cf76
Compare
a-martynovich
force-pushed
the
543-cve-page
branch
from
a681b53 to
eea540e
Compare
Hide popovers on outside click.
|
Popovers now get hidden when you click anywhere outside of them and they don't scroll the page. |
|
@a-martynovich How confident are you in this PR? As you know Roman is AFK. |
|
@vpetersson I tested it on prod data dump (in addition to the already written tests), so i'm pretty confdent about that. Code style may be questionable in some places. This PR can wait for Roman's review, no big deal, but #631 can't. |
a-martynovich
changed the title
Merged
|
Closed in favor of #639 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimisation for #617 . Should speed up CVE page load.