Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preprocess with tiling #504

Merged
merged 34 commits into from
Nov 26, 2024
Merged

Conversation

cpaniaguam
Copy link
Member

@cpaniaguam cpaniaguam commented Nov 9, 2024

Orchestration function for preprocessing with tiling.

  • Add tests

Steps 1-12 out of about 17
@cpaniaguam cpaniaguam linked an issue Nov 9, 2024 that may be closed by this pull request
@cpaniaguam cpaniaguam requested a review from a team November 15, 2024 21:58
@cpaniaguam cpaniaguam marked this pull request as ready for review November 15, 2024 21:59
danielmwatkins
danielmwatkins previously approved these changes Nov 18, 2024
Copy link
Contributor

@danielmwatkins danielmwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outlining the steps is helpful. Is there a way to easily turn the @info logging on and off if the user were to be running a batch of images?

@cpaniaguam
Copy link
Member Author

Is there a way to easily turn the @info logging on and off if the user were to be running a batch of images?

@danielmwatkins
Yes, that can be handled using a Logging configuration.

using Logging
global_logger(ConsoleLogger(stderr, Logging.Error))

This would only log Error and Fatal messages.

@cpaniaguam cpaniaguam force-pushed the 503-orchestrate-into-a-macro-function branch from ac1f891 to 727b154 Compare November 19, 2024 21:16
danielmwatkins
danielmwatkins previously approved these changes Nov 20, 2024
danielmwatkins
danielmwatkins previously approved these changes Nov 20, 2024
@cpaniaguam cpaniaguam requested review from danielmwatkins and a team November 20, 2024 18:14
Copy link
Collaborator

@tdivoll tdivoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions for clarifications and adding k to the docstrings.

src/histogram_equalization.jl Show resolved Hide resolved
src/histogram_equalization.jl Show resolved Hide resolved
src/ice_masks.jl Show resolved Hide resolved
src/ice_masks.jl Show resolved Hide resolved
src/ice_masks.jl Show resolved Hide resolved
src/preprocess_tiling.jl Show resolved Hide resolved
src/watershed.jl Show resolved Hide resolved
Copy link
Collaborator

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one comment on the code.

One question: does anything need to change in the CLI to make this work, or will it just slot in?

src/histogram_equalization.jl Show resolved Hide resolved
@cpaniaguam
Copy link
Member Author

One question: does anything need to change in the CLI to make this work, or will it just slot in?

@hollandjg
This function processes one unit of input data in the same way preprocess does. It will need a wrapper that leverages it (like the namesake preprocess does.

@cpaniaguam cpaniaguam merged commit 8ad0ea8 into main Nov 26, 2024
7 checks passed
@cpaniaguam cpaniaguam deleted the 503-orchestrate-into-a-macro-function branch November 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orchestrate into a macro function
4 participants