-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preprocess with tiling #504
Conversation
Steps 1-12 out of about 17
All steps Factor as function
Refactor the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outlining the steps is helpful. Is there a way to easily turn the @info logging on and off if the user were to be running a batch of images?
@danielmwatkins using Logging
global_logger(ConsoleLogger(stderr, Logging.Error)) This would only log |
ac1f891
to
727b154
Compare
…vert to grayscale
…prove ice label processing logic
0adb46f
to
b28f0e8
Compare
It was crashing for me. CP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions for clarifications and adding k
to the docstrings.
Co-authored-by: Timothy Divoll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just one comment on the code.
One question: does anything need to change in the CLI to make this work, or will it just slot in?
@hollandjg |
Orchestration function for preprocessing with tiling.