476 feat morph fill #478
Merged
476 feat morph fill #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
tdivoll
previously approved these changes
Nov 8, 2024
| @@ -79,5 +80,5 @@ julia> bridge(bw) | |||
| ``` | |||
| """ | |||
| function bridge(bw::T)::T where {T<:AbstractArray{Bool}} | |||
| return _bridge_filter(bw, _bridge_operator_lut) | |||
| return _filter(bw, _bridge_operator_lut) | |||
There was a problem hiding this comment.
I see that we already had tests set up for bridge(), this looks like just swapping in the new function name.
| function _fill_operator_lut( | ||
| I::CartesianIndex{2}, | ||
| img::AbstractArray{Bool}, | ||
| nhood::CartesianIndices{2,Tuple{UnitRange{Int64},UnitRange{Int64}}}, |
There was a problem hiding this comment.
Nice flexibility to work with different neighborhood sizes!
|
|
||
| r = rand(1:100) | ||
|
|
||
| imgbig = repeat(img, r, r) |
There was a problem hiding this comment.
This seems robust, does it make an image 100x bigger with random perimeters that need to be filled or the same size img with the perimeter in random locations?
There was a problem hiding this comment.
It would repeat that basic block r times across and down. Say that r takes up the value 2. Then imgbig would look like this
[
B B
B B
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476