Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: regularize/final #500

Merged
merged 23 commits into from
Nov 19, 2024
Merged

feat: regularize/final #500

merged 23 commits into from
Nov 19, 2024

Conversation

cpaniaguam
Copy link
Member

@cpaniaguam cpaniaguam commented Nov 7, 2024

@cpaniaguam cpaniaguam linked an issue Nov 7, 2024 that may be closed by this pull request
@cpaniaguam cpaniaguam self-assigned this Nov 7, 2024
@cpaniaguam cpaniaguam requested review from hollandjg, tdivoll and a team November 7, 2024 14:23
- `factor`: The factor to apply to the local maxima mask.
- `segment_mask`: The segment mask -- intersection of bw1 and bw2 in first tiled workflow of `master.m`.
"""
function get_new3(img, L0mask, radius, amount, local_maxima_mask, factor, segment_mask, se)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptive title: "sharpen_and_reconstruct"

@cpaniaguam cpaniaguam changed the title feat: get_new2/3/final feat: regularize/final Nov 14, 2024
danielmwatkins
danielmwatkins previously approved these changes Nov 18, 2024
Copy link
Contributor

@danielmwatkins danielmwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new names, and thanks for adding detailed docstrings!

@cpaniaguam cpaniaguam merged commit f6551c7 into main Nov 19, 2024
7 checks passed
@cpaniaguam cpaniaguam deleted the 493-get_new23-final branch November 19, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_new2/3
2 participants