Specify lookback window #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
requested changes
Jul 26, 2023
apasel422
reviewed
Jul 26, 2023
apasel422
requested changes
Jul 26, 2023
apasel422
requested changes
Jul 26, 2023
vikassahu29
reviewed
Jul 26, 2023
apasel422
approved these changes
Jul 27, 2023
vikassahu29
approved these changes
Jul 31, 2023
johnivdel
reviewed
Aug 1, 2023
apasel422
reviewed
Aug 2, 2023
csharrison
approved these changes
Aug 3, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 4, 2023
Support lookback window by adding an optional reserved keyword `lookback_window` to trigger's filters. spec: WICG/attribution-reporting-api#914 When set, the field is parsed as a duration in seconds. To decide if a filter matches, we first check the lookback window. If available, the duration since the source was registered must be smaller or equal to the lookback window duration. Backward compatibility: by introducing a new reserved keyword, the spec breaks source registrations which are currently using the `lookback_window` key. To ease migration, we don't yet prevent sources from using the `lookback_window` key and we process a trigger's `lookback_window` key as other filter keys when its associated value is a list of strings. OBSOLETE_HISTOGRAM[Conversions.SourceRegistrationError3]=Replaced with Conversions.SourceRegistrationError4 due to addition of new enum value. Change-Id: Ie87e9613493fa3b00e04567d712f7ef64e193e89 Bug: 1469316,1468973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4727801 Reviewed-by: John Delaney <[email protected]> Commit-Queue: Anthony Garant <[email protected]> Reviewed-by: Andrew Paseltiner <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Cr-Commit-Position: refs/heads/main@{#1179638}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #769
Support lookback window by adding an optional reserved keyword "_lookback_window" to trigger's filters.
When set, the field is parsed as a duration in seconds.
To decide if a filter matches, we first check the lookback window. If available, the duration since the source was registered must be smaller or equal to the lookback window duration.
Backward incompatibility: By introducing a new reserved keyword, we break source registrations which are currently using the "_lookback_window" key.
Preview | Diff