Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve all keys beginning with _ #930

Closed
agarant opened this issue Aug 3, 2023 · 0 comments · Fixed by #967
Closed

Reserve all keys beginning with _ #930

agarant opened this issue Aug 3, 2023 · 0 comments · Fixed by #967
Assignees
@agarant

Comments

@agarant
Copy link
Contributor

agarant commented Aug 3, 2023

The _ prefix was used in #914.

However, the change still introduced a backward incompatibility as keys prefixed with _ are not currently reserved.

Reserving these keys would simplify future changes similar to this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agarant agarant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reserve keys starting with an underscore agarant/attribution-reporting-api
1 participant
@agarant