Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Simulation Setup #53

Merged
merged 23 commits into from
Mar 5, 2024
Merged

Add Simulation Setup #53

merged 23 commits into from
Mar 5, 2024

Conversation

VishGit1234
Copy link
Contributor

Add the following to the monorepo:

  • CARLA and CARLA ROS Bridge
  • CARLA Viz Tool
  • Jupyter Notebook Server with CARLA dependencies
  • Python sample node for CARLA

@VishGit1234 VishGit1234 requested a review from Edwardius February 4, 2024 00:53
@VishGit1234 VishGit1234 marked this pull request as draft February 4, 2024 00:54
@VishGit1234 VishGit1234 marked this pull request as ready for review February 4, 2024 01:44
Edwardius
Edwardius requested changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@Edwardius Edwardius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Couple of comments here and there, but it should be ready to merge in no time

.github/include/base_image_config.json Outdated Show resolved Hide resolved
.github/workflows/build_base_images.yml Outdated Show resolved Hide resolved
docker/simulation/carla_ros_bridge/carla_ros_bridge.Dockerfile Outdated Show resolved Hide resolved
docker/simulation/carla_ros_bridge/carla_ros_bridge.Dockerfile Outdated Show resolved Hide resolved
docker/simulation/carla_ros_bridge/carla_ros_bridge.Dockerfile Outdated Show resolved Hide resolved
src/simulation/carla_config/src/carla_mpc_bridge.cpp Outdated Show resolved Hide resolved
src/simulation/carla_config/src/carla_mpc_bridge.cpp Outdated Show resolved Hide resolved
src/simulation/carla_config/src/carla_mpc_bridge.cpp Outdated Show resolved Hide resolved
src/wato_msgs/simulation/common_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
src/wato_msgs/simulation/path_planning_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
@Edwardius
Copy link
Collaborator

Is this ready for rereview?

@VishGit1234
Copy link
Contributor Author

VishGit1234 commented Feb 14, 2024 •
edited
Loading

Is this ready for rereview?

Not yet, been a bit busy I'll try and get it done this weekend. I'll definitely let you know when it is ready for rereview

@VishGit1234
Copy link
Contributor Author

Done addressing the PR comments @Edwardius . Please take a look when you have a chance

Edwardius
Edwardius approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@Edwardius Edwardius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make the small changes, resolve conflict, and ur good to go!

docker/simulation/carla_ros_bridge/carla_ros_bridge.Dockerfile Outdated Show resolved Hide resolved
docker/simulation/carla_sample_node/carla_sample_node.Dockerfile Outdated Show resolved Hide resolved
src/simulation/carla_config/package.xml Outdated Show resolved Hide resolved
src/simulation/carla_config/src/carla_mpc_bridge.cpp Outdated Show resolved Hide resolved
@VishGit1234 VishGit1234 force-pushed the simulation-new branch 3 times, most recently from 944b3d5 to 785771f Compare March 3, 2024 19:32
@VishGit1234 VishGit1234 added the auto-lint Automatically lints your code (does not commit) label Mar 4, 2024
@github-actions github-actions bot removed the auto-lint Automatically lints your code (does not commit) label Mar 4, 2024
@VishGit1234 VishGit1234 added the auto-lint Automatically lints your code (does not commit) label Mar 4, 2024
@github-actions github-actions bot removed the auto-lint Automatically lints your code (does not commit) label Mar 4, 2024
@VishGit1234 VishGit1234 added the auto-lint Automatically lints your code (does not commit) label Mar 4, 2024
@github-actions github-actions bot removed the auto-lint Automatically lints your code (does not commit) label Mar 4, 2024
@VishGit1234 VishGit1234 merged commit b3cd2db into main Mar 5, 2024
29 of 34 checks passed
@VishGit1234 VishGit1234 deleted the simulation-new branch March 5, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edwardius Edwardius Edwardius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VishGit1234 @Edwardius @WATonomousAdmin